Wrong type declaration for `attr-lowercase`

[gian1200]

Description

Not sure where is the validation happening, but this warning is a mistake. This property should accepts an array of strings.

https://htmlhint.com/rules/attr-lowercase/

Warning

ENV:

• OS: Windows 11
• VSCode version: v1.102.0
• Extension version: v1.11.1

.htmlhintrc:

{
	"alt-require": true,
	"attr-lowercase": [
		"allowReorder",
		"attributeName",
		"attributeType",
		"autoReverse",
		"baseFrequency",
		"baseProfile",
		"calcMode",
		"clipPath",
		"clipPathUnits",
		"contentScriptType",
		"contentStyleType",
		"diffuseConstant",
		"edgeMode",
		"externalResourcesRequired",
		"filterRes",
		"filterUnits",
		"glyphRef",
		"gradientTransform",
		"gradientUnits",
		"kernelMatrix",
		"kernelUnitLength",
		"keyPoints",
		"keySplines",
		"keyTimes",
		"lengthAdjust",
		"limitingConeAngle",
		"markerHeight",
		"markerUnits",
		"markerWidth",
		"maskContentUnits",
		"maskUnits",
		"numOctaves",
		"onBlur",
		"onChange",
		"onClick",
		"onFocus",
		"onKeyUp",
		"onLoad",
		"pathLength",
		"patternContentUnits",
		"patternTransform",
		"patternUnits",
		"pointsAtX",
		"pointsAtY",
		"pointsAtZ",
		"preserveAlpha",
		"preserveAspectRatio",
		"primitiveUnits",
		"refX",
		"refY",
		"repeatCount",
		"repeatDur",
		"requiredExtensions",
		"requiredFeatures",
		"specularConstant",
		"specularExponent",
		"spreadMethod",
		"startOffset",
		"stdDeviation",
		"stitchTiles",
		"surfaceScale",
		"systemLanguage",
		"tableValues",
		"targetX",
		"targetY",
		"textLength",
		"viewBox",
		"viewTarget",
		"xChannelSelector",
		"yChannelSelector",
		"zoomAndPan"
	],
	"attr-no-duplication": true,
	"attr-unsafe-chars": true,
	"attr-value-double-quotes": true,
	"attr-value-not-empty": false,
	"doctype-first": true,
	"doctype-html5": true,
	"head-script-disabled": true,
	"href-abs-or-rel": "rel",
	"id-class-ad-disabled": true,
	"id-class-value": "dash",
	"id-unique": true,
	"inline-script-disabled": false,
	"inline-style-disabled": false,
	"space-tab-mixed-disabled": "tab",
	"spec-char-escape": true,
	"src-not-empty": true,
	"style-disabled": true,
	"tag-pair": true,
	"tag-self-close": true,
	"tagname-lowercase": true,
	"title-require": true
}

PS: it'd be nice if the validation message shows that it comes from this extension (same way rules do). Had to disable/enable the extension to confirm it's origin.

[coliff]

ah, I think that comes from this file.. https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/htmlhint.json
I'll open a PR with the suggested fix today or tomorrow (theres a few other small changes to make there as well).

[coliff]

also, FYI- you don't need to list SVG attributes there anymore, they are ignored by default...
https://github.com/htmlhint/HTMLHint/blob/main/src/core/rules/attr-lowercase.ts

[gian1200]

Thanks for your comment!

Yes, I realized the same when reading the docs to write this issue.

I initially built our .htmlhintrc based on your comment from htmlhint/HTMLHint#542 (comment) (4 years ago 🤯).

[coliff]

The JSON Schema was updated today with the 4 most recently added rules...
https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/htmlhint.json
However, I need to make a separate PR to allow array for attr-lowercase and attr-value-no-duplication, but I'm not sure of the exact way to specify that in the JSON file..