Skip to content

Commit e4f129e

Browse files
authored
Merge pull request #222 from zhangyongding/fix-oralce-limit
fix oracle limit bug
2 parents 87617c3 + 81eb13e commit e4f129e

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

select.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,6 @@ func (sb *SelectBuilder) BuildWithFlavor(flavor Flavor, initialArg ...interface{
580580
} else {
581581
buf.WriteString("1 AND ")
582582
buf.WriteString(sb.limitVar)
583-
buf.WriteString(" + 1")
584583
}
585584
} else {
586585
// As oraclePage is true, sb.offsetVar must not be empty.

select_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ func ExampleSelectBuilder_limit_offset() {
263263
// #1: SELECT * FROM user
264264
// #2: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r >= :1 + 1
265265
// #3: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r BETWEEN :1 + 1 AND :2 + :3
266-
// #4: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r BETWEEN 1 AND :1 + 1
266+
// #4: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user) user) WHERE r BETWEEN 1 AND :1
267267
// #5: SELECT * FROM (SELECT ROWNUM r, * FROM (SELECT * FROM user ORDER BY id) user) WHERE r BETWEEN :1 + 1 AND :2 + :3
268268
//
269269
// Informix

0 commit comments

Comments
 (0)