Skip to content

Conversation

@yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented Oct 23, 2025

w/ FP-Quant PR IST-DASLab/FP-Quant#11 merged, all pseudoquant cases pass with triton kernel on XPU. For next-gen XPU which support native mxfp4/nvfp4, will upstream once they are ready. @ydshieh, pls help review, thx very much.

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
@yao-matrix yao-matrix marked this pull request as draft October 23, 2025 22:55
@yao-matrix yao-matrix marked this pull request as ready for review October 27, 2025 15:49
@github-actions github-actions bot requested review from SunMarc and ydshieh October 27, 2025 15:50
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XPU!

"""

quantization_config = cls.getQuantizationConfig()
cls.quantization_config = cls.getQuantizationConfig()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @SunMarc could have a second look here.

@yao-matrix
Copy link
Contributor Author

@SunMarc , could you pls take a look? Thx very much.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending this to XPU

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: fp_quant_integration

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc SunMarc enabled auto-merge (squash) November 5, 2025 10:42
@SunMarc SunMarc merged commit 36b6405 into huggingface:main Nov 5, 2025
23 checks passed
@yao-matrix yao-matrix deleted the fp_quant-xpu branch November 6, 2025 16:32
Abdennacer-Badaoui pushed a commit to Abdennacer-Badaoui/transformers that referenced this pull request Nov 10, 2025
* extend fp_quant UTs to xpu

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>

* fix style

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>

* Update tests/quantization/fp_quant_integration/test_fp_quant.py

Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com>

---------

Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com>
Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants