feat(cb): use context manager in generate_batch
#42190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-or
reviewed
Nov 13, 2025
Collaborator
remi-or
left a comment
remi-or
left a comment
There was a problem hiding this comment.
I have a few comments, otherwise looks good!
src/transformers/generation/continuous_batching/continuous_api.py
Outdated
Show resolved
Hide resolved
| try: | ||
| from tqdm.contrib.logging import logging_redirect_tqdm | ||
|
|
||
| with logging_redirect_tqdm([logger]): |
Collaborator
There was a problem hiding this comment.
to decrease indentation level, we put the two context managers on the same line
src/transformers/generation/continuous_batching/continuous_api.py
Outdated
Show resolved
Hide resolved
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
McPatate
changed the title
generate_batch\generate_batch
remi-or
reviewed
Nov 14, 2025
src/transformers/generation/continuous_batching/continuous_api.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Diff is weird, I think you need to rebase. Then I can approve! |
McPatate
force-pushed
the
feat/use_context_manager_in_generate_batch
branch
from
54764a8 to
239f094
Compare
Member
Author
quizz time: what command did I use to rebase without any conflict? |
McPatate
force-pushed
the
feat/use_context_manager_in_generate_batch
branch
2 times, most recently
from
69351e4 to
180b53c
Compare
Co-authored-by: Rémi Ouazan <83456801+remi-or@users.noreply.github.com>
McPatate
force-pushed
the
feat/use_context_manager_in_generate_batch
branch
from
180b53c to
7827090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.