Skip to content

Commit 23178fb

Browse files
authored
ci: simplify check-guest-i686 to only test i686 builds (#1102)
The recipe was rebuilding x86_64 guests with/without tracing, which is out of scope for a recipe named check-guest-i686. Now it only: 1. Verifies hyperlight-guest builds for i686 2. Verifies trace_guest correctly fails on i686 (compile_error) The x86_64 tracing tests are already covered by other CI jobs. Signed-off-by: danbugs <danilochiarlone@gmail.com>
1 parent 7a41b91 commit 23178fb

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

Justfile

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -202,15 +202,8 @@ test-rust-tracing target=default-target features="":
202202
# verify hyperlight-guest builds for 32-bit (for Nanvix compatibility - uses i686 as proxy for Nanvix's custom 32-bit x86 target)
203203
check-guest-i686 target=default-target:
204204
cargo check -p hyperlight-guest --target i686-unknown-linux-gnu --profile={{ if target == "debug" { "dev" } else { target } }}
205-
206-
# Build the tracing guest to ensure it builds with the tracing feature
207-
just build-rust-guests {{ target }} trace_guest
208-
just move-rust-guests {{ target }}
209-
210-
# Rebuild the tracing guests without the tracing feature
211-
# This is to ensure that the tracing feature does not affect the other tests
212-
just build-rust-guests {{ target }}
213-
just move-rust-guests {{ target }}
205+
# Verify that trace_guest correctly fails on i686 (compile_error should trigger)
206+
! cargo check -p hyperlight-guest --target i686-unknown-linux-gnu --features trace_guest --profile={{ if target == "debug" { "dev" } else { target } }} 2>/dev/null
214207

215208
test-doc target=default-target features="":
216209
{{ cargo-cmd }} test --profile={{ if target == "debug" { "dev" } else { target } }} {{ target-triple-flag }} {{ if features =="" {''} else { "--features " + features } }} --doc

0 commit comments

Comments
 (0)