updated to latest parser gem

Author: catmando

docs/development-workflow/hyper-spec/03-methods-and-features.md

@@ -75,8 +75,9 @@ See the [Client Initialization Options](#client-initialization-options) section
 
 By default the client environment will be reinitialized at the beginning of every spec.  If this is not needed you can speed things up by adding the `no_reset` flag to a block of specs.
 
-> Note if you are using `visit` to directly load a page and still want to use methods like `on_client` and the expectation helpers, see the last section on
-using visit at the end of this document.
+### Known Issues
+
+See the last section below for known issues.
 
 # Details
 
@@ -442,10 +443,29 @@ The method is typically not needed assuming you are using a multithreaded server
 
 You can resolve this by using the `pause` method in the debug session which will put the server debug session into a non-blocking loop.  You can then experiment in the JS console, and when done release the pause by executing `go()` in the *javascript* debug console.
 
-### Using `visit` and the Application Layout
+### Known Issues
+
+####Using `visit` and the Application Layout
 Currently this is not well integrated (see [issue 398](https://github.com/hyperstack-org/hyperstack/issues/398)).  If you want to visit a page on the website
 using `visit`, the following will not work: Timecop integration, and the `insert_html` and `before_mount` methods.  You will also have to execute this line in your spec:
 ```ruby
 page.instance_variable_set("@hyper_spec_mounted", true)
 ```
 Upvote issue 398 if this presents a big problem for you.
+
+#### Some Complex Expressions Do Not Work
+[Issue 127](https://github.com/hyperstack-org/hyperstack/issues/127)
+
+You may get an error like this when running a spec:
+
+```text
+(string):1:20: error: unexpected token tOP_ASGN
+(string):1: hash.[]("foo") += 1
+(string):1:
+```
+
+The problem is the unparser incorrectly generates `hash.[]("foo") += 1` instead of `hash['foo'] += 1`.
+
+The good news its pretty easy to find such expressions and replace them with something like
+
+`hash["foo"] = hash["foo"] + 1`

ruby/hyper-spec/hyper-spec.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   # spec.add_dependency 'libv8', '~> 7.3.492.27.1'
   spec.add_dependency 'method_source'
   spec.add_dependency 'opal', ENV['OPAL_VERSION'] || '>= 0.11.0', '< 2.0'
-  spec.add_dependency 'parser', '>= 2.3.3.1'  # on rails-6 this is now >= 2.3
+  spec.add_dependency 'parser', '>= 3.0' #'>= 2.3.3.1'  # on rails-6 this is now >= 2.3
   spec.add_dependency 'rspec'
   spec.add_dependency 'selenium-webdriver'
   spec.add_dependency 'timecop', '~> 0.8.1'
@@ -56,7 +56,7 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   spec.add_development_dependency 'rspec-its'
   spec.add_development_dependency 'rspec-mocks'
   spec.add_development_dependency 'rspec-steps', '~> 2.1.1'
-  spec.add_development_dependency 'rubocop', '~> 0.51.0'
+  spec.add_development_dependency 'rubocop' #, '~> 0.51.0'
   spec.add_development_dependency 'shoulda'
   spec.add_development_dependency 'shoulda-matchers'
   spec.add_development_dependency 'spring-commands-rspec'

ruby/hyper-spec/lib/hyper-spec.rb

@@ -37,7 +37,15 @@
   nil
 end
 
-Parser::Builders::Default.emit_procarg0 = true
+# opt-in to most recent AST format:
+Parser::Builders::Default.emit_lambda              = true
+Parser::Builders::Default.emit_procarg0            = true
+Parser::Builders::Default.emit_encoding            = true
+Parser::Builders::Default.emit_index               = true
+Parser::Builders::Default.emit_arg_inside_procarg0 = true
+Parser::Builders::Default.emit_forward_arg         = true
+Parser::Builders::Default.emit_kwargs              = true
+Parser::Builders::Default.emit_match_pattern       = true
 
 # not available in parser 2.3
 if Parser::Builders::Default.respond_to? :emit_arg_inside_procarg0

ruby/hyper-spec/spec/hyper_spec.rb

@@ -462,6 +462,14 @@ class << self
     it 'allows local variables on the client to be set using the with method' do
       expect { with_var * 2 }.with(with_var: 4).on_client_to eq(8)
     end
+
+    it "works with complex expressions" do
+      expect do
+        hash = { 'foo' =>  1}
+        hash['foo'] += 1
+        hash['foo']
+      end.on_client_to eq(2)
+    end
   end
 
   it "will use the arity_check option" do