-
Notifications
You must be signed in to change notification settings - Fork 4
Description
For historical reasons, the Popover
component sets overflow-y-auto overflow-x-hidden
to the outermost element. These were required for the first use case of the Popover, the Select
dropdown.
This has been okeyish until we have had the need to support adding an arrow to the popover, where we had to conditionally set those only for Popovers without arrow, and use overflow-visible
for Popover with arrow (see #2014 for details).
This presents a not so obvious difference in the Popover behavior when using an arrow vs not using it.
We should change this so that the Popover always sets overflow-visible
(to overwrite the default styles of [popover]
), and consumers override this behavior if needed, like in the case of the Select.
This has the risk of introducing a regression, so it would be good to test that the places where we are currently using Popover keep working as expected.