invalidateDecorationsAllViews - not working?

[Johannes-repos]

I am trying to link external sensor data from a Home Assistant https://www.home-assistant.io/ / https://www.npmjs.com/package/homeassistant instance into the viewer app.
Data is coming in fine and is displayed by the decorators.

Values for this sensor are updated every 10 seconds.

To update the live data feed, I am trying to use:

`

  setInterval( () => {
    const d=new SmartDeviceDecorator(vp);
    console.log(IModelApp.viewManager.dropDecorator(d));
    IModelApp.viewManager.invalidateDecorationsAllViews();
    IModelApp.viewManager.invalidateCachedDecorationsAllViews(d);
    IModelApp.viewManager.addDecorator(d);

    vp.invalidateDecorations(); // Refresh the markers on the screen
  }, 5000);

`

Instead of updating or removing the decorators every 5 seconds, a new decorator is added.
As visible above, the sun icon gets more and more blurry.

Here’s a link to a video describing the issue:

https://www.dropbox.com/s/o8bbna3co27xiii/invalidateDecorationsAllViews.mp4?dl=0

Any idea how I could resolve this?

Thanks

[pmconne]

Based on your code snippet, you create and add a new SmartDeviceDecorator every 5 seconds, and never drop the previously-added ones.
Try something like:

setInterval(() => {
  const oldDecorator = IModelApp.viewManager.decorators.find((dec) => dec instanceof SmartDeviceDecorator);
  if (oldDecorator)
    IModelApp.viewManager.dropDecorator(oldDecorator);

  IModelApp.viewManager.addDecorator(new SmartDeviceDecorator(vp));
}, 5000);

Alternatively, if there's only ever one SmartDeviceDecorator, just store the most recent one in some variable instead of searching for it.

Note: add/dropDecorator take care of invalidating decorations - you should not have to do that yourself here.

[Johannes-repos]

Hi Paul,

thanks for your quick reply and you're solution worked perfectly!