Skip to content

Add types from index to quarterOfYear #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add types from index to quarterOfYear #2823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf419cf
Add types from index to quarterOfYeari
bensaufley Feb 4, 2025
d8f63d0
This might be a better solution - fix QUnitType and add ManipulateQType
bensaufley Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,14 @@ declare namespace dayjs {

export type UnitType = UnitTypeLong | UnitTypeLongPlural | UnitTypeShort;

type WithQuarters<T> = T | 'quarter' | 'quarters' | 'Q';

export type OpUnitType = UnitType | "week" | "weeks" | 'w';
export type QUnitType = UnitType | "quarter" | "quarters" | 'Q';
export type QUnitType = WithQuarters<OpUnitType>;

export type ManipulateType = Exclude<OpUnitType, 'date' | 'dates'>;
export type ManipulateQType = WithQuarters<ManipulateType>;

class Dayjs {
constructor (config?: ConfigType)
/**
Expand Down
10 changes: 5 additions & 5 deletions types/plugin/quarterOfYear.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { PluginFunc, ConfigType, QUnitType, OpUnitType } from 'dayjs'
import { PluginFunc, ConfigType, ManipulateQType, QUnitType } from 'dayjs'

declare const plugin: PluginFunc
export = plugin
Expand All @@ -9,13 +9,13 @@ declare module 'dayjs' {

quarter(quarter: number): Dayjs

add(value: number, unit: QUnitType): Dayjs
add(value: number, unit: ManipulateQType): Dayjs

subtract(value: number, unit: QUnitType): Dayjs
subtract(value: number, unit: ManipulateQType): Dayjs

startOf(unit: QUnitType | OpUnitType): Dayjs
startOf(unit: QUnitType): Dayjs

endOf(unit: QUnitType | OpUnitType): Dayjs
endOf(unit: QUnitType): Dayjs

isSame(date?: ConfigType, unit?: QUnitType): boolean

Expand Down
Loading