feat: Add support for tls type and skip verification #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the Kafka Connect Elasticsearch sink connector, primarily focused on enhancing TLS configuration flexibility and updating documentation. The most significant changes are the addition of support for custom keystore/truststore types and the option to skip SSL verification, along with corresponding updates to documentation and configuration files.
TLS Configuration Enhancements
JKS,PKCS12, etc.) via new configuration optionses.tls.keystore.typeandes.tls.truststore.type, with defaults set toJKS. These are now handled in both the connector and writer classes and passed to the Jetty SSL context. [1] [2] [3] [4] [5]es.tls.skip.verificationto allow skipping SSL verification for Elasticsearch connections. This is configurable and logged as a warning if enabled. [1] [2] [3] [4] [5]Documentation and Example Updates
README.mdto document the new TLS configuration options, including keystore/truststore types and SSL verification skipping. Improved formatting and added code blocks for clarity. [1] [2] [3] [4]config/elastic-sink.propertiesto include the new TLS options and clarify their usage.Dependency Update
3.6.1to4.0.0inpom.xmlfor improved compatibility and access to new features.Minor Documentation Improvements
README.md, such as code block formatting, improved list readability, and fixed license URL formatting. [1] [2] [3] [4] [5] [6]These changes collectively improve the connector's security configuration flexibility and make it easier for users to understand and configure TLS options.