Merge pull request #1191 from jrmoreno1/Issue1170

VB -> C#: Brackets needed around ternary expression

Author: GrahamTheCoder

CodeConverter/CSharp/CommonConversions.cs

@@ -523,6 +523,10 @@ private async Task<ExpressionSyntax> IncreaseArrayUpperBoundExpressionAsync(VBSy
             && convertedExpression.SkipIntoParens() is CSSyntax.BinaryExpressionSyntax bExp && bExp.IsKind(CSSyntaxKind.SubtractExpression))
             return bExp.Left;
 
+        if (convertedExpression is CSSyntax.ConditionalExpressionSyntax ce) {
+            convertedExpression = SyntaxFactory.ParenthesizedExpression(convertedExpression);
+        }
+
         return SyntaxFactory.BinaryExpression(
             CSSyntaxKind.SubtractExpression,
             convertedExpression, SyntaxFactory.Token(CSSyntaxKind.PlusToken), SyntaxFactory.LiteralExpression(CSSyntaxKind.NumericLiteralExpression, SyntaxFactory.Literal(1)));

Tests/CSharp/ExpressionTests/AccessExpressionTests.cs

@@ -209,6 +209,26 @@ public string[][] GetStringsFromAmbiguous(int amb)
 }");
     }
 
+    [Fact]
+    public async Task TernaryArrayIndexerAsync()
+    {
+        await TestConversionVisualBasicToCSharpAsync(@"Public Class A
+    Public Sub Test()
+        Dim i as integer = 0
+        Dim a(If(i = 1, 2, 3)) as string
+    End Sub
+End Class", @"
+public partial class A
+{
+    public void Test()
+    {
+        int i = 0;
+        var a = new string[(i == 1 ? 2 : 3) + 1];
+    }
+}");
+    }
+
+
     [Fact]
     public async Task ElementAtOrDefaultIndexingAsync()
     {