Fails to convert multiple NativeMethod Files From C# To VB

[vshanecurtis]

I have been attempting to convert API DLLImport statements from several projects and your code converter fails in spectacular fashion, producing a screenful of errors. Some examples you can test are x360ce-master,pinvoke-main, and Vanara-master. All these projects contain extensive collections of DLLImport statements for multiple DLLs. They are all written in gags C#. I would like to convert these imports into VB so I can create a class library that I can include in my projects

[GrahamTheCoder]

Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line?

[vshanecurtis]

I gave you specific the names of specific projects on Git Hub that are producing errors. That should be sufficient. They ALL fail no matter what I do

…

________________________________ From: Graham ***@***.***> Sent: Thursday, March 27, 2025 4:57 AM To: icsharpcode/CodeConverter ***@***.***> Cc: vshanecurtis ***@***.***>; Author ***@***.***> Subject: Re: [icsharpcode/CodeConverter] C# -> VB: _Add a short description_Fails to convert multiple NativeMethod Files From C# To VB (Issue #1171) Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line? — Reply to this email directly, view it on GitHub<#1171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNWXRMYLOLLFBUYEP4ZJYTD2WOVOZAVCNFSM6AAAAABZ34RHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJXGIZTQMBZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***> [GrahamTheCoder]GrahamTheCoder left a comment (icsharpcode/CodeConverter#1171)<#1171 (comment)> Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line? — Reply to this email directly, view it on GitHub<#1171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNWXRMYLOLLFBUYEP4ZJYTD2WOVOZAVCNFSM6AAAAABZ34RHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJXGIZTQMBZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[vshanecurtis]

I'm going to dig into this a little more on my end. I think something on my system may be out of whack. The converter was working fine then it started doing this. I ran it against files that were already converted and it did the same thing. I don't think it likes having VS 2019 and VS 20222 on the same machine. I had to because there is a bug in 2022. Changing the startup form breaks the project. A suggested fix was to load the project into 2019 change it then reload in 2022. That's hit and miss. I can't believe that MS did this and still has not fixed it.

…

________________________________ From: Graham ***@***.***> Sent: Thursday, March 27, 2025 4:57 AM To: icsharpcode/CodeConverter ***@***.***> Cc: vshanecurtis ***@***.***>; Author ***@***.***> Subject: Re: [icsharpcode/CodeConverter] C# -> VB: _Add a short description_Fails to convert multiple NativeMethod Files From C# To VB (Issue #1171) Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line? — Reply to this email directly, view it on GitHub<#1171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNWXRMYLOLLFBUYEP4ZJYTD2WOVOZAVCNFSM6AAAAABZ34RHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJXGIZTQMBZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***> [GrahamTheCoder]GrahamTheCoder left a comment (icsharpcode/CodeConverter#1171)<#1171 (comment)> Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line? — Reply to this email directly, view it on GitHub<#1171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNWXRMYLOLLFBUYEP4ZJYTD2WOVOZAVCNFSM6AAAAABZ34RHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJXGIZTQMBZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[vshanecurtis]

OK, I uninstalled vs 2019 and vs 2020. I reinstalled vs 2020. I then installed your addin and fed it a C# code module that it should have been able to convert but it did the same thing that it's been doing. The message box that appears on the screen is quite large. It covers the entire height of the screen. Please advise.

…

________________________________ From: Graham ***@***.***> Sent: Thursday, March 27, 2025 4:57 AM To: icsharpcode/CodeConverter ***@***.***> Cc: vshanecurtis ***@***.***>; Author ***@***.***> Subject: Re: [icsharpcode/CodeConverter] C# -> VB: _Add a short description_Fails to convert multiple NativeMethod Files From C# To VB (Issue #1171) Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line? — Reply to this email directly, view it on GitHub<#1171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNWXRMYLOLLFBUYEP4ZJYTD2WOVOZAVCNFSM6AAAAABZ34RHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJXGIZTQMBZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***> [GrahamTheCoder]GrahamTheCoder left a comment (icsharpcode/CodeConverter#1171)<#1171 (comment)> Thanks for the report, could you link to a specific file that failed spectacularly, and confirm whether you were using the visual studio extension or command line? — Reply to this email directly, view it on GitHub<#1171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNWXRMYLOLLFBUYEP4ZJYTD2WOVOZAVCNFSM6AAAAABZ34RHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJXGIZTQMBZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[GrahamTheCoder]

When there's a message box like that you can usually press ctrl c to copy the text. Can you send that or a print screen?

The extension isn't supposed to load in any version below VS2022 (17.6), but I've spotted an issue which is might make it try to load in earlier versions which I'll prevent.

[vshanecurtis]

OK, I'm not sure what has happened, but it seems like it has decided to start cooperating again. I've fed it a few files that I am pretty sure produced the massive error list and it processed them without complaint. I will continue to try to find a file that produces the "Messagebox From Hell". If I'm successful I'll capture it and send the file as well.

[vshanecurtis]

I found a file that produces the type of error I spoke of. Even after I stripped it down to the basic part I needed the code fails to convert. It won't let me upload it directly so here it is cut/paste:

`//
// Copyright (c) 2007 Ole André Vadla Ravnås oleavr@gmail.com
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with this program. If not, see http://www.gnu.org/licenses/.
//

using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using System.Runtime.InteropServices;

namespace oSpy.Capture
{
public class DeviceEnumerator
{
private string id;
public string Id
{
get { return id; }
}

    public DeviceEnumerator (string id)
    {
        this.id = id;
    }

    public static DeviceEnumerator USB = new DeviceEnumerator ("USB");
}

public class DeviceList : IDisposable
{
    private IntPtr devInfo = IntPtr.Zero;

    private List<Device> devices = new List<Device> ();
    public List<Device> Devices
    {
        get { return devices; }
    }

    public DeviceList (DeviceEnumerator enumerator)
    {
        devInfo = WinApi.SetupDiGetClassDevs (IntPtr.Zero, enumerator.Id, IntPtr.Zero, WinApi.DIGCF_ALLCLASSES | WinApi.DIGCF_PROFILE);
        if (devInfo.ToInt32 () != WinApi.INVALID_HANDLE_VALUE)
            devices = EnumerateDevices (devInfo);
    }

    public void Dispose ()
    {
        Dispose (true);
        GC.SuppressFinalize (this);
    }

    protected virtual void Dispose (bool disposing)
    {
        if (disposing)
            devices.Clear ();

        if (devInfo != IntPtr.Zero)
        {
            WinApi.SetupDiDestroyDeviceInfoList (devInfo);
            devInfo = IntPtr.Zero;
        }
    }

    ~DeviceList ()
    {
        Dispose (false);
    }

    private static List<Device> EnumerateDevices (IntPtr devInfo)
    {
        List<Device> devices = new List<Device> ();
        Dictionary<string, Device> devicesByHwId = new Dictionary<string, Device> ();

        for (uint i = 0; ; i++)
        {
            WinApi.SP_DEVINFO_DATA devInfoData = new WinApi.SP_DEVINFO_DATA ();
            devInfoData.cbSize = (uint)Marshal.SizeOf (devInfoData);

            if (!WinApi.SetupDiEnumDeviceInfo (devInfo, i, ref devInfoData))
                break;

            Device device = Device.FromDevInfo (devInfo, devInfoData);
            if (device != null)
            {
                if (!devicesByHwId.ContainsKey (device.HardwareId))
                {
                    devicesByHwId[device.HardwareId] = device;

                    devices.Add (device);
                }
                else
                {
                    // TODO: should solve this differently, the hardware
                    //       IDs aren't unique...
                }
            }
        }

        return devices;
    }
}

public class Device
{
    private IntPtr devInfo;
    private WinApi.SP_DEVINFO_DATA devInfoData;

    private string name;
public string Name
{
  get { return name; }
}

    private string hardwareId;
    public string HardwareId
    {
        get { return hardwareId; }
    }

    private string physicalDeviceObjectName;
    public string PhysicalDeviceObjectName
    {
        get { return physicalDeviceObjectName; }
    }

    private UInt32 capabilities;
    public UInt32 Capabilities
    {
        get { return capabilities; }
    }

    public bool Present
    {
        get { return physicalDeviceObjectName != null; }
    }

    private static DeviceClassImageList classImageList = new DeviceClassImageList ();

    private Icon smallIcon = null;
    public Icon SmallIcon
    {
        get
        {
            EnsureIcons ();
            return smallIcon;
        }
    }

    private Icon largeIcon = null;
    public Icon LargeIcon
    {
        get
        {
            EnsureIcons ();
            return largeIcon;
        }
    }

    public string[] LowerFilters
    {
        get { return GetRegistryPropertyMultiString (WinApi.SPDRP_LOWERFILTERS); }
    }

    private Device (IntPtr devInfo, WinApi.SP_DEVINFO_DATA devInfoData, string name, string hardwareId, string physicalDeviceObjectName, UInt32 capabilities)
    {
        this.devInfo = devInfo;
        this.devInfoData = devInfoData;
        this.name = name;
        this.hardwareId = hardwareId;
        this.physicalDeviceObjectName = physicalDeviceObjectName;
        this.capabilities = capabilities;
    }

    private bool iconsLoaded = false;

    private void EnsureIcons ()
    {
        if (iconsLoaded)
            return;

        iconsLoaded = true;

        LoadIcons (out smallIcon, out largeIcon);
    }

    private bool LoadIcons (out Icon smallIcon, out Icon largeIcon)
    {
        smallIcon = null;
        largeIcon = null;

        IntPtr smallIconHandle = IntPtr.Zero;
        IntPtr largeIconHandle = IntPtr.Zero;

        try
        {
            System.OperatingSystem osInfo = System.Environment.OSVersion;
            Version osVer = osInfo.Version;

            // Are we on Vista or newer?
            if (osInfo.Platform == PlatformID.Win32NT && osVer >= new Version (6, 0))
            {
                if (!WinApi.SetupDiLoadDeviceIcon (devInfo, ref devInfoData, 16, 16, 0, out smallIconHandle))
                    return false;
            }
            else
            {
                // Get the small icon's index
                int smallIconIndex;
                WinApi.SP_CLASSIMAGELIST_DATA clsImageListData = classImageList.Data;

                WinApi.SetupDiGetClassImageIndex (ref clsImageListData, ref devInfoData.ClassGuid, out smallIconIndex);

                // Retrieve the small icon
                smallIconHandle = WinApi.ImageList_GetIcon (clsImageListData.ImageList, smallIconIndex, 1);
                if (smallIconHandle == IntPtr.Zero)
                    return false;
            }

            // Get the large icon
            int miniIconIndex;
            if (!WinApi.SetupDiLoadClassIcon (ref devInfoData.ClassGuid, out largeIconHandle, out miniIconIndex))
                return false;

            // Create the icons in the managed world
            try
            {
                smallIcon = Icon.FromHandle (smallIconHandle);
                smallIconHandle = IntPtr.Zero;
                largeIcon = Icon.FromHandle (largeIconHandle);
                largeIconHandle = IntPtr.Zero;
            }
            catch (Exception)
            {
                return false;
            }
        }
        finally
        {
            if (smallIconHandle != IntPtr.Zero)
                WinApi.DestroyIcon (smallIconHandle);

            if (largeIconHandle != IntPtr.Zero)
                WinApi.DestroyIcon (largeIconHandle);
        }

        return true;
    }

    private string[] GetRegistryPropertyMultiString (uint property)
    {
        string[] value = new string [0];

        byte[] buf = new byte[1024];
        uint reqBufSize;
        if (WinApi.SetupDiGetDeviceRegistryProperty (devInfo, ref devInfoData, property, IntPtr.Zero, buf, (uint) buf.Length, out reqBufSize))
            value = WinApi.MarshalMultiStringToStringArray (buf);

        return value;
    }

    private void SetRegistryPropertyMultiString (uint property, string[] value)
    {
        byte[] buf = WinApi.MarshalStringArrayToMultiString (value);
        if (!WinApi.SetupDiSetDeviceRegistryProperty (devInfo, ref devInfoData, property, buf, (uint)buf.Length))
            throw new Exception (String.Format ("SetupDiSetDeviceRegistryProperty failed with error 0x{0:x8}", Marshal.GetLastWin32Error ()));
    }

    public bool HasLowerFilter (string name)
    {
        return Array.IndexOf<string> (LowerFilters, name) >= 0;
    }

    public void AddLowerFilter (string name)
    {
        List<string> filters = new List<string> (LowerFilters);
        if (filters.Contains (name))
            return;

        filters.Add (name);

        SetRegistryPropertyMultiString (WinApi.SPDRP_LOWERFILTERS, filters.ToArray ());
    }

    public void RemoveLowerFilter (string name)
    {
        List<string> filters = new List<string> (LowerFilters);
        if (!filters.Contains (name))
            return;

        while (filters.Remove (name));

        SetRegistryPropertyMultiString (WinApi.SPDRP_LOWERFILTERS, filters.ToArray ());
    }

    public void Restart ()
    {
        WinApi.SP_PROPCHANGE_PARAMS p = new WinApi.SP_PROPCHANGE_PARAMS ();
        p.ClassInstallHeader.cbSize = (uint) Marshal.SizeOf (p.ClassInstallHeader);
        p.ClassInstallHeader.InstallFunction = WinApi.DIF_PROPERTYCHANGE;

        p.StateChange = WinApi.DICS_PROPCHANGE;
        p.Scope = WinApi.DICS_FLAG_CONFIGSPECIFIC;
        p.HwProfile = 0;

        if (!WinApi.SetupDiSetClassInstallParams (devInfo, ref devInfoData, ref p, Marshal.SizeOf (p)))
            throw new Error ("SetupDiSetClassInstallParams failed");

        if (!WinApi.SetupDiCallClassInstaller (WinApi.DIF_PROPERTYCHANGE, devInfo, ref devInfoData))
            throw new Error ("SetupDiCallClassInstaller failed");
    }

    public static Device FromDevInfo (IntPtr devInfo, WinApi.SP_DEVINFO_DATA devInfoData)
    {
        Device device = null;

        string name = null;
        string hardwareId = null;
        string physicalDeviceObjectName = null;
        UInt32 capabilities = 0;

        byte[] buf = new byte[1024];
        uint reqBufSize;

        if (WinApi.SetupDiGetDeviceRegistryProperty (devInfo, ref devInfoData, WinApi.SPDRP_FRIENDLYNAME, IntPtr.Zero, buf, (uint) buf.Length, out reqBufSize))
        {
            name = WinApi.ByteArrayToString (buf);
        }

        if (name == null)
        {
            if (WinApi.SetupDiGetDeviceRegistryProperty (devInfo, ref devInfoData, WinApi.SPDRP_DEVICEDESC, IntPtr.Zero, buf, (uint)buf.Length, out reqBufSize))
            {
                name = WinApi.ByteArrayToString (buf);
            }
        }

        if (WinApi.SetupDiGetDeviceRegistryProperty (devInfo, ref devInfoData, WinApi.SPDRP_HARDWAREID, IntPtr.Zero, buf, (uint)buf.Length, out reqBufSize))
        {
            string[] tokens = WinApi.MarshalMultiStringToStringArray (buf);
            hardwareId = String.Join (";", tokens);
        }

        if (WinApi.SetupDiGetDeviceRegistryProperty (devInfo, ref devInfoData, WinApi.SPDRP_PHYSICAL_DEVICE_OBJECT_NAME, IntPtr.Zero, buf, (uint)buf.Length, out reqBufSize))
        {
            physicalDeviceObjectName = WinApi.ByteArrayToString (buf);
        }

        if (WinApi.SetupDiGetDeviceRegistryProperty (devInfo, ref devInfoData, WinApi.SPDRP_CAPABILITIES, IntPtr.Zero, buf, (uint)buf.Length, out reqBufSize))
        {
            capabilities = BitConverter.ToUInt32 (buf, 0);
        }

        if (name != null && hardwareId != null)
        {
            device = new Device (devInfo, devInfoData, name, hardwareId, physicalDeviceObjectName, capabilities);
        }

        return device;
    }
}

public class DeviceClassImageList
{
    private bool dataLoaded = false;
    private WinApi.SP_CLASSIMAGELIST_DATA data;
    public WinApi.SP_CLASSIMAGELIST_DATA Data
    {
        get
        {
            if (!dataLoaded)
            {
                dataLoaded = true;
                data = new WinApi.SP_CLASSIMAGELIST_DATA ();
                data.cbSize = (uint)Marshal.SizeOf (data);
                WinApi.SetupDiGetClassImageList (ref data);
            }

            return data;
        }
    }

    public void Dispose ()
    {
        Dispose (true);
        GC.SuppressFinalize (this);
    }

    protected virtual void Dispose (bool disposing)
    {
        if (dataLoaded)
        {
            dataLoaded = false;
            WinApi.SetupDiDestroyClassImageList (ref data);
        }
    }

    ~DeviceClassImageList ()
    {
        Dispose (false);
    }
}

}
`