permit comparing net::Inet with net::ip4::Addr and net::ip6::Addr

while this can be done explicitly if we know if our ip type is ip4 or
ip6, this allows us to pass `auto ip` to the comparison

Author: mazunki

api/net/addr.hpp

@@ -122,6 +122,19 @@ union Addr {
   bool operator<=(const Addr& other) const noexcept
   { return (*this < other or *this == other); }
 
+
+  bool operator==(const net::ip4::Addr& other) const noexcept
+  { return ip4_.addr == other; }
+
+  bool operator!=(const net::ip4::Addr& other) const noexcept
+  { return ip4_.addr != other; }
+
+  bool operator==(const net::ip6::Addr& other) const noexcept
+  { return ip6_ == other; }
+
+  bool operator!=(const net::ip6::Addr& other) const noexcept
+  { return ip6_ != other; }
+
 private:
   struct {
     uint64_t  big;
@@ -135,4 +148,10 @@ union Addr {
 
 static_assert(sizeof(Addr) == sizeof(ip6::Addr));
 
+inline bool operator==(const ip4::Addr& lhs, const Addr& rhs) noexcept { return rhs == lhs; }
+inline bool operator!=(const ip4::Addr& lhs, const Addr& rhs) noexcept { return !(lhs == rhs); }
+
+inline bool operator==(const ip6::Addr& lhs, const Addr& rhs) noexcept { return rhs == lhs; }
+inline bool operator!=(const ip6::Addr& lhs, const Addr& rhs) noexcept { return !(lhs == rhs); }
+
 }

api/net/inet.hpp

@@ -535,4 +535,34 @@ namespace net {
   };
 }
 
+namespace net::ip4 {
+  inline bool operator==(const net::ip4::Addr& lhs, const net::Inet& rhs) noexcept {
+    return lhs == rhs.ip_addr();
+  }
+  inline bool operator==(const net::Inet& lhs, const net::ip4::Addr& rhs) noexcept {
+    return lhs.ip_addr() == rhs;
+  }
+  inline bool operator!=(const net::ip4::Addr& lhs, const net::Inet& rhs) noexcept {
+    return !(lhs == rhs);
+  }
+  inline bool operator!=(const net::Inet& lhs, const net::ip4::Addr& rhs) noexcept {
+    return !(lhs == rhs);
+  }
+}  // namespace net::ip4
+
+namespace net::ip6 {
+  inline bool operator==(const net::ip6::Addr& lhs, const net::Inet& rhs) noexcept {
+      return lhs == rhs.ip6_addr();
+  }
+  inline bool operator==(const net::Inet& lhs, const net::ip6::Addr& rhs) noexcept {
+      return lhs.ip6_addr() == rhs;
+  }
+  inline bool operator!=(const net::ip6::Addr& lhs, const net::Inet& rhs) noexcept {
+      return !(lhs == rhs);
+  }
+  inline bool operator!=(const net::Inet& lhs, const net::ip6::Addr& rhs) noexcept {
+      return !(lhs == rhs);
+  }
+} // namespace net::ip6
+
 #endif

test/unit/net/router_test.cpp

@@ -191,6 +191,8 @@ CASE("net::router: Actual routing verifying TTL")
     auto packet = static_unique_ptr_cast<net::PacketIP4>(std::move(pckt));
     EXPECT(packet->ip_protocol() == Protocol::ICMPv4);
     EXPECT(packet->ip_ttl() == PacketIP4::DEFAULT_TTL);
+    EXPECT(ip == src.address());
+    EXPECT(ip.is_loopback() == false);
 
     auto icmp = icmp4::Packet(std::move(packet));
     ICMP_error err{icmp.type(), icmp.code()};
@@ -208,6 +210,8 @@ CASE("net::router: Actual routing verifying TTL")
     EXPECT(packet->destination() == dst);
     EXPECT(packet->ip_ttl() == (PacketIP4::DEFAULT_TTL-1));
 
+    EXPECT(ip == dst.address());
+    EXPECT(ip.is_loopback() == false);
     tcp_packet_recv++;
   });