IWF-836: SDK expects stateWaitUntilFailed flag instead stateStartApiSucceeded (#301)

samuel27m · web-flow · commit 85209ea56fe2 · 2025-06-19T09:04:07.000+01:00
diff --git a/iwf-idl b/iwf-idl
@@ -1 +1 @@
-Subproject commit 08e49fcf69e59d1df30babc076d1f2b49f07dc82
+Subproject commit 5a96d629c6e337cdc8f363dc52a6965e02a1c0ec
diff --git a/src/main/java/io/iworkflow/core/mapper/CommandResultsMapper.java b/src/main/java/io/iworkflow/core/mapper/CommandResultsMapper.java
@@ -39,8 +39,13 @@ public static CommandResults fromGenerated(
                             objectEncoder))
                     .collect(Collectors.toList()));
         }
-        if(commandResults.getStateStartApiSucceeded() != null) {
-            builder.waitUntilApiSucceeded(commandResults.getStateStartApiSucceeded());
+
+        // The server will set stateWaitUntilFailed to true if the waitUntil API failed.
+        // Hence, flag inversion is needed here to indicate that the waitUntil API
+        // succeeded.
+        builder.waitUntilApiSucceeded(true);
+        if (Boolean.TRUE.equals(commandResults.getStateWaitUntilFailed())) {
+            builder.waitUntilApiSucceeded(false);
         }
         return builder.build();
     }

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,13 @@ public static CommandResults fromGenerated(`
`39`	`39`	`objectEncoder))`
`40`	`40`	`.collect(Collectors.toList()));`
`41`	`41`	`}`
`42`		`- if(commandResults.getStateStartApiSucceeded() != null) {`
`43`		`- builder.waitUntilApiSucceeded(commandResults.getStateStartApiSucceeded());`
	`42`	`+`
	`43`	`+ // The server will set stateWaitUntilFailed to true if the waitUntil API failed.`
	`44`	`+ // Hence, flag inversion is needed here to indicate that the waitUntil API`
	`45`	`+ // succeeded.`
	`46`	`+ builder.waitUntilApiSucceeded(true);`
	`47`	`+ if (Boolean.TRUE.equals(commandResults.getStateWaitUntilFailed())) {`
	`48`	`+ builder.waitUntilApiSucceeded(false);`
`44`	`49`	`}`
`45`	`50`	`return builder.build();`
`46`	`51`	`}`