Skip to content

Commit bad98fc

Browse files
[NOBUG]Fix PersistenceOptions comment to remove RPC (#304)
1 parent d73acfa commit bad98fc

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/main/java/io/iworkflow/core/persistence/PersistenceOptions.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,11 @@
44

55
@Value.Immutable
66
public abstract class PersistenceOptions {
7-
// This option will enable caching persistence (data/search attributes) so that the readonly-RPC or GetDataAttributes API can
7+
// This option will enable caching persistence (data/search attributes) so that GetDataAttributes and GetSearchAttributes API can
88
// support a much higher throughput on a single workflow execution.
99
// NOTES:
10-
// 1. The read after write will become eventual consistent, unless set bypassCachingForStrongConsistency to true in RPC annotation
11-
// 2. The caching is implemented by Temporal upsertMemo feature. Only iWF service with Temporal as backend is supporting this feature at the moment
12-
// 3. It will extra cost as it will upsertMemo(WorkflowPropertiesModified event in the history) for write
13-
// 4. Only useful for read-only RPC(no persistence.SetXXX API or communication API calls)
10+
// 1. The caching is implemented by Temporal upsertMemo feature. Only iWF service with Temporal as backend supports this feature ATM.
11+
// 2. It will cost extra action/event on updating data attribute, as iwf-server will upsertMemo(WorkflowPropertiesModified event in the history)
1412
public abstract boolean getEnableCaching();
1513

1614
public static PersistenceOptions getDefault() {

0 commit comments

Comments
 (0)