safety on job

drusepth · drusepth · commit af9b47839ef2 · 2021-10-25T21:06:07.000-07:00
diff --git a/app/jobs/cache_sum_attribute_word_count_job.rb b/app/jobs/cache_sum_attribute_word_count_job.rb
@@ -6,8 +6,9 @@ def perform(*args)
     entity_id   = args.shift
 
     entity = entity_type.constantize.find_by(id: entity_id)
-    sum_attribute_word_count = Attribute.where(entity_type: entity_type, entity_id: entity_id).sum(:word_count_cache)
+    return if entity.nil?
 
+    sum_attribute_word_count = Attribute.where(entity_type: entity_type, entity_id: entity_id).sum(:word_count_cache)
     update = entity.word_count_updates.find_or_initialize_by(
       for_date: DateTime.current,
     )

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,9 @@ def perform(*args)`
`6`	`6`	`entity_id = args.shift`
`7`	`7`
`8`	`8`	`entity = entity_type.constantize.find_by(id: entity_id)`
`9`		`- sum_attribute_word_count = Attribute.where(entity_type: entity_type, entity_id: entity_id).sum(:word_count_cache)`
	`9`	`+ return if entity.nil?`
`10`	`10`
	`11`	`+ sum_attribute_word_count = Attribute.where(entity_type: entity_type, entity_id: entity_id).sum(:word_count_cache)`
`11`	`12`	`update = entity.word_count_updates.find_or_initialize_by(`
`12`	`13`	`for_date: DateTime.current,`
`13`	`14`	`)`