Skip to content

Commit af34bda

Browse files
Make ARG version required
Signed-off-by: Evgeniy Dikevich <evgeny.dikevich@innowise.com>
1 parent 03b3478 commit af34bda

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

earthly/flutter/installer/Earthfile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ ARG --global BASE_URL = "https://iog-catalyst-storage.s3.eu-central-1.amazonaws.
2121
INSTALL_CHROME_LINUX64:
2222
FUNCTION
2323

24-
ARG version
24+
ARG --required version
2525
ARG TARGETARCH
2626
LET BLUE='\033[0;34m'
2727

@@ -53,13 +53,13 @@ INSTALL_CHROME_LINUX64:
5353
RUN chromedriver --version
5454
END
5555

56-
# Install Firefox and Geckodriver from hardcoded GitHub-hosted locations.
56+
# Install Firefox and Geckodriver from AWS S3 bucket.
5757
# Geckodriver supported versions:
5858
# https://firefox-source-docs.mozilla.org/testing/geckodriver/Support.html
5959
INSTALL_FIREFOX_LINUX64:
6060
FUNCTION
6161

62-
ARG version
62+
ARG --required version
6363
ARG TARGETARCH
6464
LET PLATFORM = ""
6565
LET BLUE = '\033[0;34m'
@@ -88,13 +88,11 @@ INSTALL_FIREFOX_LINUX64:
8888
RUN ln -s /opt/geckodriver/geckodriver /usr/bin/geckodriver
8989
RUN geckodriver --version
9090

91-
# TODO(minikin): https://github.com/input-output-hk/catalyst-ci/issues/308
92-
# Install Edge and EdgeDriver.
9391
# There is no Edge version build for linux/arm64, installing only for amd64.
9492
INSTALL_EDGE_LINUX64:
9593
FUNCTION
9694

97-
ARG version
95+
ARG --required version
9896
ARG TARGETARCH
9997
LET BLUE ='\033[0;34m'
10098

@@ -114,10 +112,11 @@ INSTALL_EDGE_LINUX64:
114112
END
115113

116114
# Installs the Chromium or Chromium driver.
115+
# Both amd64 and arm64 are supported.
117116
INSTALL_CHROMIUM:
118117
FUNCTION
119118

120-
ARG version
119+
ARG --required version
121120
ARG --required PACKAGE_TYPE
122121
ARG --required DOWNLOAD_URL
123122
LET BLUE='\033[0;34m'

0 commit comments

Comments
 (0)