DocumentOwnershipRule validation rule initialisation (#587)

Author: stanislav-tkach

rust/catalyst-signed-doc-spec/src/signers/mod.rs

@@ -1,10 +1,12 @@
 //! 'signers' field definition
 
 pub mod roles;
+pub mod update;
 
 /// Document's 'signers' fields definition
 #[derive(serde::Deserialize)]
 #[allow(clippy::missing_docs_in_private_items)]
 pub struct Signers {
     pub roles: roles::Roles,
+    pub update: update::Update,
 }

rust/catalyst-signed-doc-spec/src/signers/update.rs

@@ -0,0 +1,10 @@
+//! 'updates' field definition
+
+/// Document's 'updates' fields definition.
+#[derive(serde::Deserialize)]
+#[allow(clippy::missing_docs_in_private_items)]
+pub struct Update {
+    pub author: bool,
+    #[serde(default)]
+    pub collaborators: bool,
+}

rust/signed_doc/src/validator/rules/mod.rs

@@ -116,8 +116,7 @@ impl Rules {
     ///  - `signed_doc.json` filed loading and JSON parsing errors.
     ///  - `catalyst-signed-doc-spec` crate version doesn't  align with the latest version
     ///    of the `signed_doc.json`.
-    pub(crate) fn documents_rules(
-    ) -> anyhow::Result<impl Iterator<Item = (crate::DocType, crate::validator::rules::Rules)>>
+    pub(crate) fn documents_rules() -> anyhow::Result<impl Iterator<Item = (crate::DocType, Rules)>>
     {
         let spec = catalyst_signed_doc_spec::CatalystSignedDocSpec::load_signed_doc_spec()?;
 
@@ -141,9 +140,7 @@ impl Rules {
                 content: ContentRule::new(&doc_spec.payload)?,
                 kid: SignatureKidRule::new(&doc_spec.signers.roles)?,
                 signature: SignatureRule { mutlisig: false },
-                ownership: DocumentOwnershipRule {
-                    allow_collaborators: false,
-                },
+                ownership: DocumentOwnershipRule::new(&doc_spec.signers.update)?,
             };
             let doc_type = doc_spec.doc_type.parse()?;
 

rust/signed_doc/src/validator/rules/ownership/mod.rs

@@ -5,6 +5,8 @@ mod tests;
 
 use std::collections::HashSet;
 
+use anyhow::ensure;
+use catalyst_signed_doc_spec::signers::update::Update;
 use catalyst_types::catalyst_id::CatalystId;
 
 use crate::{providers::CatalystSignedDocumentProvider, CatalystSignedDocument};
@@ -28,10 +30,19 @@ fn single_author_check(doc: &CatalystSignedDocument) -> bool {
 #[derive(Debug)]
 pub(crate) struct DocumentOwnershipRule {
     /// Collaborators are allowed.
-    pub(crate) allow_collaborators: bool,
+    allow_collaborators: bool,
 }
 
 impl DocumentOwnershipRule {
+    /// Creates `DocumentOwnershipRule` from specs.
+    pub(crate) fn new(spec: &Update) -> anyhow::Result<Self> {
+        ensure!(spec.author, "'author' field must always be equal to `true`");
+
+        Ok(Self {
+            allow_collaborators: spec.collaborators,
+        })
+    }
+
     /// Check document ownership rule
     pub(crate) async fn check<Provider>(
         &self,