fix(general): Update rust to 1.89 and rust-ci to 3.5.10 (#501)

* fix: bump rustci from 3.5.7 to 3.5.10

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: bump rust from 1.88 to 1.89

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix: allow explicit_deref_methods

Signed-off-by: bkioshn <bkioshn@gmail.com>

---------

Signed-off-by: bkioshn <bkioshn@gmail.com>

Author: bkioshn

rust/Earthfile

@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.7 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.5.10 AS rust-ci
 IMPORT ../ AS repo-ci
 
 COPY_SRC:

rust/c509-certificate/Earthfile

@@ -1,6 +1,6 @@
 VERSION 0.8
 
-IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust::v3.5.7 AS rust-ci
+IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust::v3.5.10 AS rust-ci
 
 IMPORT .. AS rust-local
 IMPORT ../.. AS repo

rust/cardano-chain-follower/src/mithril_snapshot_config.rs

@@ -452,9 +452,8 @@ fn check_writable(path: &Path) -> bool {
     }
 
     // Can't read the directory for any reason, so can't write to the directory.
-    let path_iterator = match path.read_dir() {
-        Err(_) => return false,
-        Ok(entries) => entries,
+    let Ok(path_iterator) = path.read_dir() else {
+        return false;
     };
 
     // Recursively check the contents of the directory

rust/catalyst-voting/benches/vote_protocol.rs

@@ -8,7 +8,8 @@
     missing_docs,
     clippy::missing_docs_in_private_items,
     clippy::unwrap_used,
-    clippy::similar_names
+    clippy::similar_names,
+    clippy::explicit_deref_methods
 )]
 
 use catalyst_voting::{

rust/catalyst-voting/src/crypto/babystep_giantstep.rs

@@ -101,6 +101,7 @@ impl BabyStepGiantStep {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use std::ops::Mul;
 

rust/catalyst-voting/src/crypto/zk_unit_vector/decoding.rs

@@ -155,6 +155,7 @@ impl ResponseRandomness {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use test_strategy::proptest;
 

rust/catalyst-voting/src/crypto/zk_unit_vector/mod.rs

@@ -285,6 +285,7 @@ mod arbitrary_impl {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use proptest::sample::size_range;
     use rand_core::OsRng;

rust/catalyst-voting/src/vote_protocol/voter/decoding.rs

@@ -84,6 +84,7 @@ impl VoterProof {
 }
 
 #[cfg(test)]
+#[allow(clippy::explicit_deref_methods)]
 mod tests {
     use std::io::Cursor;
 

rust/catalyst-voting/tests/voting_test.rs

@@ -1,4 +1,5 @@
 //! A general voting integration test, which performs a full voting procedure.
+#![allow(clippy::explicit_deref_methods)]
 
 use catalyst_voting::vote_protocol::{
     committee::ElectionSecretKey,

rust/rbac-registration/src/cardano/cip509/validation.rs

@@ -127,7 +127,7 @@ pub fn validate_stake_public_key(
     let context = "Cip509 stake public key validation";
 
     let transaction = MultiEraTx::Conway(Box::new(Cow::Borrowed(transaction)));
-    let witness = match TxnWitness::new(&[transaction.clone()]) {
+    let witness = match TxnWitness::new(std::slice::from_ref(&transaction)) {
         Ok(w) => w,
         Err(e) => {
             report.other(&format!("Failed to create TxWitness: {e:?}"), context);