resolved review comments

Author: curiecrypt

mithril-stm/src/membership_commitment/merkle_tree/commitment.rs

@@ -1,13 +1,12 @@
-use std::marker::PhantomData;
-
+use anyhow::{Context, anyhow};
 use blake2::digest::{Digest, FixedOutput};
 use serde::{Deserialize, Serialize};
+use std::marker::PhantomData;
 
 use crate::membership_commitment::merkle_tree::{
     MerkleBatchPath, MerklePath, MerkleTreeLeaf, parent, sibling,
 };
 use crate::{MerkleTreeError, StmResult};
-use anyhow::{Context, anyhow};
 
 /// `MerkleTree` commitment.
 /// This structure differs from `MerkleTree` in that it does not contain all elements, which are not always necessary.

mithril-stm/src/membership_commitment/merkle_tree/path.rs

@@ -1,8 +1,8 @@
+use blake2::digest::{Digest, FixedOutput};
+use serde::{Deserialize, Serialize};
 use std::marker::PhantomData;
 
 use crate::{MerkleTreeError, StmResult};
-use blake2::digest::{Digest, FixedOutput};
-use serde::{Deserialize, Serialize};
 
 /// Path of hashes from root to leaf in a Merkle Tree.
 /// Contains all hashes on the path, and the index of the leaf.

mithril-stm/src/protocol/mod.rs

@@ -9,9 +9,13 @@ mod single_signature;
 pub use aggregate_signature::{
     AggregateSignature, AggregateSignatureType, AggregateVerificationKey, BasicVerifier, Clerk,
 };
-pub use error::*;
-pub use key_registration::*;
-pub use parameters::*;
+pub(crate) use eligibility_check::is_lottery_won;
+pub use error::{
+    AggregateSignatureError, AggregationError, MerkleTreeError, MultiSignatureError, RegisterError,
+    SignatureError, blst_error_to_stm_error,
+};
+pub use key_registration::{ClosedKeyRegistration, KeyRegistration, RegisteredParty};
+pub use parameters::Parameters;
 pub use participant::{Initializer, Signer, VerificationKey, VerificationKeyProofOfPossession};
 pub use single_signature::{SingleSignature, SingleSignatureWithRegisteredParty};
 

mithril-stm/src/protocol/participant/signer.rs

@@ -1,10 +1,7 @@
 use blake2::digest::{Digest, FixedOutput};
 
 use crate::signature_scheme::{BlsSignature, BlsSigningKey, BlsVerificationKey};
-use crate::{
-    ClosedKeyRegistration, Parameters, SingleSignature, Stake,
-    protocol::eligibility_check::is_lottery_won,
-};
+use crate::{ClosedKeyRegistration, Parameters, SingleSignature, Stake, is_lottery_won};
 
 /// Wrapper of the MultiSignature Verification key
 pub type VerificationKey = BlsVerificationKey;