MCP Connector invalid typing of arguments

[bartfo]

Hey everyone,

I'm having issues with Neuron's casting to MCP server's arguments.

For example, I have the following tool:

    /**
     * Adds two numbers together.
     * @param int $a The first number.
     * @param int $b The second number.
     * @return int The sum.
     */
    #[McpTool(name: 'simple_adder')]
    public function add(int $a, int $b): int
    {
        fwrite(STDERR, "Executing simple_adder with a=$a, b=$b\n");
        return $a + $b;
    }

that is properly resolved to the following

^ array:3 [
  "name" => "simple_adder"
  "description" => "Adds two numbers together."
  "inputSchema" => array:3 [
    "type" => "object"
    "properties" => array:2 [
      "a" => array:2 [
        "type" => "integer"
        "description" => "The first number."
      ]
      "b" => array:2 [
        "type" => "integer"
        "description" => "The second number."
      ]
    ]
    "required" => array:2 [
      0 => "a"
      1 => "b"
    ]
  ]
]

in McpConnector::createTool.

However, the final call in McpClient::callTool is:

^ array:4 [
  "jsonrpc" => "2.0"
  "id" => 3
  "method" => "tools/call"
  "params" => array:2 [
    "name" => "simple_adder"
    "arguments" => array:2 [
      0 => 3
      1 => 512
    ]
  ]
]

Because we have positional array instead of ['a' => 3, b => 512] the whole logic crashes with:

In McpConnector.php line 47:
                                                                                                        
  Invalid parameters for tool 'simple_adder': Invalid type. Expected `object`, but received `unknown`.  

am I missing something?

If I force ['a' => 3, b => 512] to 'arguments' it works properly.

Am I missing something? Why the arguments aren't a and b respectively but 0 and 1?

[ilvalerione]

Hi @bartfo the latest release 1.12.18 could fix this issue. Let me know eventually.

[bartfo]

Appreciated, thank you