Linting fixes and updating APIs

Author: nickfloyd

github/data_source_github_organization_projects.go

@@ -116,7 +116,7 @@ func dataSourceGithubOrganizationProjects() *schema.Resource {
 	}
 }
 
-func dataSourceGithubOrganizationProjectsRead(d *schema.ResourceData, meta interface{}) error {
+func dataSourceGithubOrganizationProjectsRead(d *schema.ResourceData, meta any) error {
 	client := meta.(*Owner).v3client
 	ctx := context.Background()
 
@@ -128,13 +128,13 @@ func dataSourceGithubOrganizationProjectsRead(d *schema.ResourceData, meta inter
 	for {
 		if opts == nil {
 			opts = &github.ListProjectsOptions{
-				ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{PerPage: github.Int(100)},
+				ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{PerPage: github.Ptr(100)},
 			}
 		}
 
 		projects, resp, err := client.Projects.ListOrganizationProjects(ctx, orgName, opts)
 		if err != nil {
-			return fmt.Errorf("error listing organization Projects V2: %v", err)
+			return fmt.Errorf("error listing organization Projects V2: %w", err)
 		}
 
 		allProjects = append(allProjects, projects...)
@@ -145,18 +145,18 @@ func dataSourceGithubOrganizationProjectsRead(d *schema.ResourceData, meta inter
 
 		opts = &github.ListProjectsOptions{
 			ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{
-				PerPage: github.Int(100),
-				After:   github.String(resp.After),
+				PerPage: github.Ptr(100),
+				After:   github.Ptr(resp.After),
 			},
 		}
 	}
 
 	d.SetId(orgName)
 
-	projectsData := make([]map[string]interface{}, 0, len(allProjects))
+	projectsData := make([]map[string]any, 0, len(allProjects))
 
 	for _, project := range allProjects {
-		projectData := map[string]interface{}{
+		projectData := map[string]any{
 			"id":                project.GetID(),
 			"node_id":           project.GetNodeID(),
 			"number":            project.GetNumber(),
@@ -198,7 +198,7 @@ func dataSourceGithubOrganizationProjectsRead(d *schema.ResourceData, meta inter
 	}
 
 	if err := d.Set("projects", projectsData); err != nil {
-		return fmt.Errorf("error setting projects: %v", err)
+		return fmt.Errorf("error setting projects: %w", err)
 	}
 
 	return nil

github/data_source_github_project_fields.go

@@ -117,7 +117,7 @@ func dataSourceGithubProjectFields() *schema.Resource {
 	}
 }
 
-func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{}) error {
+func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta any) error {
 	client := meta.(*Owner).v3client
 	ctx := context.Background()
 
@@ -136,7 +136,7 @@ func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{})
 	for {
 		if opts == nil {
 			opts = &github.ListProjectsOptions{
-				ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{PerPage: github.Int(100)},
+				ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{PerPage: github.Ptr(100)},
 			}
 		}
 
@@ -150,7 +150,7 @@ func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{})
 		}
 
 		if err != nil {
-			return fmt.Errorf("error listing project fields: %v", err)
+			return fmt.Errorf("error listing project fields: %w", err)
 		}
 
 		allFields = append(allFields, fields...)
@@ -161,8 +161,8 @@ func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{})
 
 		opts = &github.ListProjectsOptions{
 			ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{
-				PerPage: github.Int(100),
-				After:   github.String(resp.After),
+				PerPage: github.Ptr(100),
+				After:   github.Ptr(resp.After),
 			},
 		}
 	}
@@ -176,10 +176,10 @@ func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{})
 	}
 	d.SetId(resourceID)
 
-	fieldsData := make([]map[string]interface{}, 0, len(allFields))
+	fieldsData := make([]map[string]any, 0, len(allFields))
 
 	for _, field := range allFields {
-		fieldData := map[string]interface{}{
+		fieldData := map[string]any{
 			"id":          field.GetID(),
 			"node_id":     field.GetNodeID(),
 			"name":        field.GetName(),
@@ -191,9 +191,9 @@ func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{})
 
 		// Add options for single_select fields
 		if len(field.Options) > 0 {
-			optionsData := make([]map[string]interface{}, 0, len(field.Options))
+			optionsData := make([]map[string]any, 0, len(field.Options))
 			for _, option := range field.Options {
-				optionData := map[string]interface{}{
+				optionData := map[string]any{
 					"id":    option.GetID(),
 					"color": option.GetColor(),
 				}
@@ -217,7 +217,7 @@ func dataSourceGithubProjectFieldsRead(d *schema.ResourceData, meta interface{})
 	}
 
 	if err := d.Set("fields", fieldsData); err != nil {
-		return fmt.Errorf("error setting fields: %v", err)
+		return fmt.Errorf("error setting fields: %w", err)
 	}
 
 	return nil

github/data_source_github_user_projects.go

@@ -116,7 +116,7 @@ func dataSourceGithubUserProjects() *schema.Resource {
 	}
 }
 
-func dataSourceGithubUserProjectsRead(d *schema.ResourceData, meta interface{}) error {
+func dataSourceGithubUserProjectsRead(d *schema.ResourceData, meta any) error {
 	client := meta.(*Owner).v3client
 	ctx := context.Background()
 
@@ -128,13 +128,13 @@ func dataSourceGithubUserProjectsRead(d *schema.ResourceData, meta interface{})
 	for {
 		if opts == nil {
 			opts = &github.ListProjectsOptions{
-				ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{PerPage: github.Int(100)},
+				ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{PerPage: github.Ptr(100)},
 			}
 		}
 
 		projects, resp, err := client.Projects.ListUserProjects(ctx, username, opts)
 		if err != nil {
-			return fmt.Errorf("error listing user Projects V2: %v", err)
+			return fmt.Errorf("error listing user Projects V2: %w", err)
 		}
 
 		allProjects = append(allProjects, projects...)
@@ -145,18 +145,18 @@ func dataSourceGithubUserProjectsRead(d *schema.ResourceData, meta interface{})
 
 		opts = &github.ListProjectsOptions{
 			ListProjectsPaginationOptions: github.ListProjectsPaginationOptions{
-				PerPage: github.Int(100),
-				After:   github.String(resp.After),
+				PerPage: github.Ptr(100),
+				After:   github.Ptr(resp.After),
 			},
 		}
 	}
 
 	d.SetId(username)
 
-	projectsData := make([]map[string]interface{}, 0, len(allProjects))
+	projectsData := make([]map[string]any, 0, len(allProjects))
 
 	for _, project := range allProjects {
-		projectData := map[string]interface{}{
+		projectData := map[string]any{
 			"id":                project.GetID(),
 			"node_id":           project.GetNodeID(),
 			"number":            project.GetNumber(),
@@ -198,7 +198,7 @@ func dataSourceGithubUserProjectsRead(d *schema.ResourceData, meta interface{})
 	}
 
 	if err := d.Set("projects", projectsData); err != nil {
-		return fmt.Errorf("error setting projects: %v", err)
+		return fmt.Errorf("error setting projects: %w", err)
 	}
 
 	return nil

github/resource_github_actions_organization_permissions.go

@@ -297,8 +297,8 @@ func resourceGithubActionsOrganizationPermissionsDelete(d *schema.ResourceData,
 	_, _, err = client.Actions.UpdateActionsPermissions(ctx,
 		orgName,
 		github.ActionsPermissions{
-			AllowedActions:      github.String("all"),
-			EnabledRepositories: github.String("all"),
+			AllowedActions:      github.Ptr("all"),
+			EnabledRepositories: github.Ptr("all"),
 		})
 	if err != nil {
 		return err

github/resource_github_actions_repository_access_level.go

@@ -46,7 +46,7 @@ func resourceGithubActionsRepositoryAccessLevelCreateOrUpdate(d *schema.Resource
 
 	accessLevel := d.Get("access_level").(string)
 	actionAccessLevel := github.RepositoryActionsAccessLevel{
-		AccessLevel: github.String(accessLevel),
+		AccessLevel: github.Ptr(accessLevel),
 	}
 
 	_, err := client.Repositories.EditActionsAccessLevel(ctx, owner, repoName, actionAccessLevel)
@@ -81,7 +81,7 @@ func resourceGithubActionsRepositoryAccessLevelDelete(d *schema.ResourceData, me
 	ctx := context.WithValue(context.Background(), ctxId, repoName)
 
 	actionAccessLevel := github.RepositoryActionsAccessLevel{
-		AccessLevel: github.String("none"),
+		AccessLevel: github.Ptr("none"),
 	}
 	_, err := client.Repositories.EditActionsAccessLevel(ctx, owner, repoName, actionAccessLevel)
 

github/resource_github_actions_repository_oidc_subject_claim_customization_template.go

@@ -117,7 +117,7 @@ func resourceGithubActionsRepositoryOIDCSubjectClaimCustomizationTemplateDelete(
 	owner := meta.(*Owner).name
 
 	customOIDCSubjectClaimTemplate := &github.OIDCSubjectClaimCustomTemplate{
-		UseDefault: github.Bool(true),
+		UseDefault: github.Ptr(true),
 	}
 
 	ctx := context.Background()

github/resource_github_actions_repository_permissions.go

@@ -222,8 +222,8 @@ func resourceGithubActionsRepositoryPermissionsDelete(d *schema.ResourceData, me
 
 	// Reset the repo to "default" settings
 	repoActionPermissions := github.ActionsPermissionsRepository{
-		AllowedActions: github.String("all"),
-		Enabled:        github.Bool(true),
+		AllowedActions: github.Ptr("all"),
+		Enabled:        github.Ptr(true),
 	}
 
 	_, _, err := client.Repositories.UpdateActionsPermissions(ctx,

github/resource_github_branch_protection_v3_utils.go

@@ -15,7 +15,7 @@ import (
 func buildProtectionRequest(d *schema.ResourceData) (*github.ProtectionRequest, error) {
 	req := &github.ProtectionRequest{
 		EnforceAdmins:                  d.Get("enforce_admins").(bool),
-		RequiredConversationResolution: github.Bool(d.Get("require_conversation_resolution").(bool)),
+		RequiredConversationResolution: github.Ptr(d.Get("require_conversation_resolution").(bool)),
 	}
 
 	rsc, err := expandRequiredStatusChecks(d)

github/resource_github_enterprise_actions_permissions.go

@@ -280,8 +280,8 @@ func resourceGithubActionsEnterprisePermissionsDelete(d *schema.ResourceData, me
 	_, _, err := client.Actions.UpdateActionsPermissionsInEnterprise(ctx,
 		d.Get("enterprise_slug").(string),
 		github.ActionsPermissionsEnterprise{
-			AllowedActions:       github.String("all"),
-			EnabledOrganizations: github.String("all"),
+			AllowedActions:       github.Ptr("all"),
+			EnabledOrganizations: github.Ptr("all"),
 		})
 	if err != nil {
 		return err

github/resource_github_enterprise_actions_workflow_permissions.go

@@ -54,11 +54,11 @@ func resourceGithubEnterpriseActionsWorkflowPermissionsCreateOrUpdate(d *schema.
 	workflowPerms := github.DefaultWorkflowPermissionEnterprise{}
 
 	if v, ok := d.GetOk("default_workflow_permissions"); ok {
-		workflowPerms.DefaultWorkflowPermissions = github.String(v.(string))
+		workflowPerms.DefaultWorkflowPermissions = github.Ptr(v.(string))
 	}
 
 	if v, ok := d.GetOk("can_approve_pull_request_reviews"); ok {
-		workflowPerms.CanApprovePullRequestReviews = github.Bool(v.(bool))
+		workflowPerms.CanApprovePullRequestReviews = github.Ptr(v.(bool))
 	}
 
 	log.Printf("[DEBUG] Updating workflow permissions for enterprise: %s", enterpriseSlug)
@@ -104,8 +104,8 @@ func resourceGithubEnterpriseActionsWorkflowPermissionsDelete(d *schema.Resource
 
 	// Reset to safe defaults
 	workflowPerms := github.DefaultWorkflowPermissionEnterprise{
-		DefaultWorkflowPermissions:   github.String("read"),
-		CanApprovePullRequestReviews: github.Bool(false),
+		DefaultWorkflowPermissions:   github.Ptr("read"),
+		CanApprovePullRequestReviews: github.Ptr(false),
 	}
 
 	_, _, err := client.Actions.UpdateDefaultWorkflowPermissionsInEnterprise(ctx, enterpriseSlug, workflowPerms)