fix(organization_ruleset): handle other error responses

[skeggse]

Resolves #2450

---

Before the change?

If an error occurs that is NOT a github.ErrorResponse or is a github.ErrorResponse with a status code other than 304 or 404 the current implementation will:

Not return from the function and continue executing and try to access resp.Header and ruleset.Name. Since both resp and ruleset are nil when there's an error we get a SIGSEGV

After the change?

• Valid error response

Pull request checklist

• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

• Yes
• No

---

[diofeher]

@skeggse Could you please add more context to the pull request's description about how you've fixed the problem and include an automated test demonstrating how this new functionality is expected to resolve the issue linked on the PR?

[nickfloyd]

@diofeher Due to the length of time it has taken to get this in, I'll step in and complete the PR description. After running some local tests this is what I came up with:

If an error occurs that is NOT a github.ErrorResponse or is a github.ErrorResponse with a status code other than 304 or 404 the current implementation will:

Not return from the function and continue executing and try to access resp.Header and ruleset.Name. Since both resp and ruleset are nil when there's an error we get a SIGSEGV

[deiga]

@nickfloyd Would there be any value in having some kind of regression test for that scenario? Maybe it could be used in the future to ensure other resources don't end up in a similar situation?