Skip to content

Conversation

@acouvreur
Copy link
Contributor

@acouvreur acouvreur commented Nov 7, 2025

Resolves #2874


Before the change?

Before the change, changing the repository name would force a renew everytime.

After the change?

Now the renew is forced only if the repository ID actually changed.

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

I'm not sure how to properly implement the tests right now, will work in this later.

Does this introduce a breaking change?

This introduce a breaking change as the internal resource ID is changed.

Please see our docs on breaking changes to help!

  • Yes
  • No

Now I'm wondering if we should instead add repository ID next to the repository name to avoid making API calls.

@nickfloyd nickfloyd moved this from Backlog to In Progress in Terraform Provider Nov 20, 2025
@nickfloyd nickfloyd added this to the v7 Next milestone Nov 20, 2025
@nickfloyd
Copy link
Member

Hey @acouvreur, let me know if you'd like to see this go our the door with the last v6.x, v7, or v7.x or if you're still working on it. ❤️

@acouvreur
Copy link
Contributor Author

Hey @acouvreur, let me know if you'd like to see this go our the door with the last v6.x, v7, or v7.x or if you're still working on it. ❤️

No pref, I didn't put too much effort into this recently unfortunately.

It's still causing us some pain in the state. But I can also take into consideration the few comments made on the original issue: #2874 (comment)

So no rush, I want this fix to be properly handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[BUG]: github_repository_collaborators error on repository rename

2 participants