[SYCL] Fix coverity issues 11/11 2025 (#20614)

This commit makes the following changes to sate Coverity:

1. Initializes uninitialized variables. This mainly affects UR handles
that are expected to be set after their corresponding UR calls.
2. Catch exceptions in dtors, similar to how we do for `*_impl` classes.
3. Fix use-after-move cases and set more appropriate ownerships.
4. Change a selection of arguments to const references.

---------

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>

Author: steffenlarsen

sycl/source/backend.cpp

@@ -223,7 +223,7 @@ make_kernel_bundle(ur_native_handle_t NativeHandle,
       sizeof(ur_device_handle_t) * NumDevices, ProgramDevices.data(), nullptr);
 
   for (auto &Dev : ProgramDevices) {
-    ur_program_binary_type_t BinaryType;
+    ur_program_binary_type_t BinaryType = UR_PROGRAM_BINARY_TYPE_NONE;
     Adapter.call<UrApiKind::urProgramGetBuildInfo>(
         UrProgram, Dev, UR_PROGRAM_BUILD_INFO_BINARY_TYPE,
         sizeof(ur_program_binary_type_t), &BinaryType, nullptr);

sycl/source/detail/adapter_impl.hpp

@@ -296,7 +296,11 @@ template <typename URResource> class Managed {
     if (!R)
       return;
 
-    Adapter->call<Release>(R);
+    try {
+      Adapter->call<Release>(R);
+    } catch (std::exception &e) {
+      __SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~Managed", e);
+    }
   }
 
   Managed retain() {

sycl/source/detail/context_impl.cpp

@@ -417,7 +417,7 @@ std::vector<ur_event_handle_t> context_impl::initializeDeviceGlobals(
       }
       // Write the pointer to the device global and store the event in the
       // initialize events list.
-      ur_event_handle_t InitEvent;
+      ur_event_handle_t InitEvent = nullptr;
       void *const &USMPtr = DeviceGlobalUSM.getPtr();
       Adapter.call<UrApiKind::urEnqueueDeviceGlobalVariableWrite>(
           QueueImpl.getHandleRef(), NativePrg,

sycl/source/detail/device_binary_image.cpp

@@ -451,6 +451,10 @@ mergeDeviceRequirements(const std::vector<const RTDeviceBinaryImage *> &Imgs) {
         size_t Pos = 0;
         do {
           const size_t NextPos = Contents.find(';', Pos);
+          if (NextPos == std::string::npos) {
+            Set.emplace(Contents.substr(Pos));
+            break;
+          }
           if (NextPos != Pos)
             Set.emplace(Contents.substr(Pos, NextPos - Pos));
           Pos = NextPos + 1;

sycl/source/detail/device_global_map_entry.cpp

@@ -38,9 +38,6 @@ DeviceGlobalUSMMem::~DeviceGlobalUSMMem() {
   } catch (std::exception &e) {
     __SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~DeviceGlobalUSMMem", e);
   }
-
-  assert(MPtr == nullptr && "MPtr has not been cleaned up.");
-  assert(MInitEvent == nullptr && "MInitEvent has not been cleaned up.");
 }
 
 OwnedUrEvent DeviceGlobalUSMMem::getInitEvent(adapter_impl &Adapter) {
@@ -86,7 +83,7 @@ DeviceGlobalMapEntry::getOrAllocateDeviceGlobalUSM(queue_impl &QueueImpl) {
   // Initialize here and save the event.
   {
     std::lock_guard<std::mutex> Lock(NewAlloc.MInitEventMutex);
-    ur_event_handle_t InitEvent;
+    ur_event_handle_t InitEvent = nullptr;
     if (MDeviceGlobalPtr) {
       // C++ guarantees members appear in memory in the order they are declared,
       // so since the member variable that contains the initial contents of the

sycl/source/detail/device_image_impl.hpp

@@ -326,7 +326,7 @@ class device_image_impl
     updateSpecConstSymMap();
   }
 
-  device_image_impl(const std::string &Src, context Context,
+  device_image_impl(const std::string &Src, const context &Context,
                     devices_range Devices, syclex::source_language Lang,
                     include_pairs_t &&IncludePairsVec, private_tag)
       : MBinImage(Src), MContext(std::move(Context)),

sycl/source/detail/device_impl.hpp

@@ -190,7 +190,7 @@ class device_impl : public std::enable_shared_from_this<device_impl> {
         return {Error};
       return {Result};
     } else {
-      ur_ret_t Result;
+      ur_ret_t Result{};
       ur_result_t Error = getAdapter().call_nocheck<UrApiKind::urDeviceGetInfo>(
           getHandleRef(), Desc, sizeof(Result), &Result, nullptr);
       if (Error == UR_RESULT_SUCCESS)
@@ -220,7 +220,7 @@ class device_impl : public std::enable_shared_from_this<device_impl> {
             getHandleRef(), Desc, ResultSize, Result.data(), nullptr);
         return Result;
       } else {
-        ur_ret_t Result;
+        ur_ret_t Result{};
         getAdapter().call<UrApiKind::urDeviceGetInfo>(
             getHandleRef(), Desc, sizeof(Result), &Result, nullptr);
         return Result;

sycl/source/detail/event_impl.hpp

@@ -318,7 +318,8 @@ class event_impl {
   ur_exp_command_buffer_sync_point_t getSyncPoint() const { return MSyncPoint; }
 
   void setCommandGraph(
-      std::shared_ptr<ext::oneapi::experimental::detail::graph_impl> Graph) {
+      const std::shared_ptr<ext::oneapi::experimental::detail::graph_impl>
+          &Graph) {
     MGraph = Graph;
   }
 

sycl/source/detail/memory_manager.cpp

@@ -445,7 +445,7 @@ void *MemoryManager::allocateMemSubBuffer(context_impl *TargetContext,
   ur_result_t Error = UR_RESULT_SUCCESS;
   ur_buffer_region_t Region = {UR_STRUCTURE_TYPE_BUFFER_REGION, nullptr, Offset,
                                SizeInBytes};
-  ur_mem_handle_t NewMem;
+  ur_mem_handle_t NewMem = nullptr;
   adapter_impl &Adapter = TargetContext->getAdapter();
   Error = Adapter.call_nocheck<UrApiKind::urMemBufferPartition>(
       ur::cast<ur_mem_handle_t>(ParentMemObj), UR_MEM_FLAG_READ_WRITE,

sycl/source/detail/program_manager/program_manager.cpp

@@ -689,6 +689,10 @@ ProgramManager::collectDeviceImageDepsForImportedSymbols(
     throw exception(make_error_code(errc::feature_not_supported),
                     "Cannot resolve external symbols, linking is unsupported "
                     "for the backend");
+
+  // Access to m_ExportedSymbolImages must be guarded by m_KernelIDsMutex.
+  std::lock_guard<std::mutex> KernelIDsGuard(m_KernelIDsMutex);
+
   while (!WorkList.empty()) {
     std::string Symbol = WorkList.front();
     WorkList.pop();