[Coverity] Potentially throwing call in an implicitly `noexcept` destructor

[AlexeySachkov]

Reported as CID 535426, you can access the Coverity scan results here: https://scan.coverity.com/projects/intel-llvm?tab=overview

llvm/sycl/source/detail/adapter_impl.hpp

Lines 295 to 300 in b152811

	~Managed() {
	if (!R)
	return;
	Adapter->call<Release>(R);
	}

All destructors are implicitly noexcept and Adapter->call may throw. I understand that there is not much we can do with respect to nicely reporting it without spending unreasonable amount of resources on this edge case (relatively speaking).

In any case I'm submitting this tracker to highlight the reported issue so that we decide on a resolution - if we decide not to fix it, we probably need to add a comment to the code to simplify Coverity issues analysis going forward.

[aelovikov-intel]

Current trunk:

llvm/sycl/source/detail/adapter_impl.hpp

Lines 295 to 304 in 111ea29

	~Managed() {
	if (!R)
	return;
	try {
	Adapter->call<Release>(R);
	} catch (std::exception &e) {
	__SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~Managed", e);
	}
	}

Looks #20614 has just addressed it.