-
Notifications
You must be signed in to change notification settings - Fork 794
[Clang][CI] Extend clang version output #20520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Changes from 3 commits
940e0dc
4c1a84c
698f908
479b59d
897670a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -23,13 +23,22 @@ jobs: | |||||||||||||||||||
| git diff --exit-code -I "^# RUN" origin/sycl-rel-6_3:sycl/test/abi/sycl_symbols_linux.dump sycl/test/abi/sycl_symbols_linux-sycl-rel-6_3.dump | ||||||||||||||||||||
| git diff --exit-code -I "^# RUN" origin/sycl-rel-6_3:sycl/test/abi/sycl_symbols_windows.dump sycl/test/abi/sycl_symbols_windows-sycl-rel-6_3.dump | ||||||||||||||||||||
|
|
||||||||||||||||||||
| get_date: | ||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||
| outputs: | ||||||||||||||||||||
| date: ${{ steps.get_date.outputs.date }} | ||||||||||||||||||||
| steps: | ||||||||||||||||||||
| - id: get_date | ||||||||||||||||||||
| run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT | ||||||||||||||||||||
|
|
||||||||||||||||||||
| ubuntu2204_build: | ||||||||||||||||||||
| needs: get_date | ||||||||||||||||||||
| if: github.repository == 'intel/llvm' | ||||||||||||||||||||
| uses: ./.github/workflows/sycl-linux-build.yml | ||||||||||||||||||||
| secrets: inherit | ||||||||||||||||||||
| with: | ||||||||||||||||||||
| build_cache_root: "/__w/" | ||||||||||||||||||||
| build_configure_extra_args: '--hip --cuda' | ||||||||||||||||||||
| build_configure_extra_args: '--hip --cuda -DSYCL_BUILD_INFO="Nightly ${{ needs.get_date.outputs.date }}"' | ||||||||||||||||||||
| build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest | ||||||||||||||||||||
|
|
||||||||||||||||||||
| retention-days: 90 | ||||||||||||||||||||
|
|
@@ -183,6 +192,7 @@ jobs: | |||||||||||||||||||
| toolchain_decompress_command: ${{ needs.ubuntu2404_oneapi_build.outputs.toolchain_decompress_command }} | ||||||||||||||||||||
|
|
||||||||||||||||||||
| build-win: | ||||||||||||||||||||
| needs: get_date | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A similar functionality is used in the tagging process below: llvm/.github/workflows/sycl-nightly.yml Lines 369 to 377 in 698f908
I suggest that we unify all places within this workflow file which rely on a date - I think that it is important that the date we put into nightly builds is aligned with tags that we push.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated here 479b59d |
||||||||||||||||||||
| uses: ./.github/workflows/sycl-windows-build.yml | ||||||||||||||||||||
| if: github.repository == 'intel/llvm' | ||||||||||||||||||||
| with: | ||||||||||||||||||||
|
|
@@ -191,7 +201,7 @@ jobs: | |||||||||||||||||||
| # functionality, make sure Linux/Windows names follow the same pattern. | ||||||||||||||||||||
| toolchain_artifact_filename: sycl_windows.tar.gz | ||||||||||||||||||||
| # Disable the spirv-dis requirement as to not require SPIR-V Tools. | ||||||||||||||||||||
| build_configure_extra_args: -DLLVM_SPIRV_ENABLE_LIBSPIRV_DIS=off | ||||||||||||||||||||
| build_configure_extra_args: -DLLVM_SPIRV_ENABLE_LIBSPIRV_DIS=off -DSYCL_BUILD_INFO="Nightly ${{ needs.get_date.outputs.date }}" | ||||||||||||||||||||
| build_target: all | ||||||||||||||||||||
|
|
||||||||||||||||||||
| e2e-win: | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2726,6 +2726,7 @@ void Driver::PrintSYCLToolHelp(const Compilation &C) const { | |
| } | ||
|
|
||
| void Driver::PrintVersion(const Compilation &C, raw_ostream &OS) const { | ||
| OS << "Intel SYCL compiler " << getSYCLBuildInfo() << " build based on:\n"; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This information would only be output via Driver invocation and other usages of
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, initially I tried to inline this into the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the info - Given that please add a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a small lit test to check if the output contains the build info. |
||
| if (IsFlangMode()) { | ||
| OS << getClangToolFullVersion("flang") << '\n'; | ||
| } else { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for debugging purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but I'd like to keep this just in case.