[SYCLLowerIR] Fix metadata format for Intel cache controls #20753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aligns metadata with the format defined in the commit message for KhronosGroup/SPIRV-LLVM-Translator@c8bfc33. Unfortunately, the format is still not documented in https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/docs/SPIRVRepresentationInLLVM.rst. This patch fixes the crash in the translator tool, which tries to handle wrong metadata format. I manually checked that the translator successfully converts properties_cache_control.cpp test to SPIR-V format with CacheControl decorations.
bader
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bader
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
approved these changes
Nov 25, 2025
Contributor
|
Windows BMG CI seems to be unstable w.r.t. timing out at the moment. It is observed elsewhere as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aligns metadata with the format defined in the commit message
for
KhronosGroup/SPIRV-LLVM-Translator@c8bfc33.
Unfortunately, the format is still not documented in
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/docs/SPIRVRepresentationInLLVM.rst.
This patch fixes the crash in the translator tool, which tries to handle
wrong metadata format. I manually checked that the translator
successfully converts properties_cache_control.cpp test to SPIR-V format
with CacheControl decorations.