From ade3a693578400530e61a5fd5370596e85d9fa12 Mon Sep 17 00:00:00 2001 From: "Larsen, Steffen" Date: Wed, 3 Dec 2025 02:56:37 -0800 Subject: [PATCH] [SYCL][Unittests] Fix IPC unittests The SYCL IPC unittests were not being build and run due to a misconfiguration. This commit fixes the configuration issue and fixes a check in two of the test cases. Signed-off-by: Larsen, Steffen --- sycl/unittests/Extensions/CMakeLists.txt | 1 + .../InterProcessCommunication/CMakeLists.txt | 4 ++-- .../Extensions/InterProcessCommunication/Memory.cpp | 12 ++++++++---- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/sycl/unittests/Extensions/CMakeLists.txt b/sycl/unittests/Extensions/CMakeLists.txt index db0bc0120e8db..a62bda555e9c9 100644 --- a/sycl/unittests/Extensions/CMakeLists.txt +++ b/sycl/unittests/Extensions/CMakeLists.txt @@ -35,3 +35,4 @@ add_subdirectory(VirtualMemory) add_subdirectory(NumComputeUnits) add_subdirectory(FreeFunctionCommands) add_subdirectory(KernelQueries) +add_subdirectory(InterProcessCommunication) diff --git a/sycl/unittests/Extensions/InterProcessCommunication/CMakeLists.txt b/sycl/unittests/Extensions/InterProcessCommunication/CMakeLists.txt index 281c6bdfe8349..424947b14bca2 100644 --- a/sycl/unittests/Extensions/InterProcessCommunication/CMakeLists.txt +++ b/sycl/unittests/Extensions/InterProcessCommunication/CMakeLists.txt @@ -2,5 +2,5 @@ add_sycl_unittest(IPCTests OBJECT Memory.cpp ) -set_target_properties(IPCTests_preview PROPERTIES CXX_STANDARD 20) -set_target_properties(IPCTests_non_preview PROPERTIES CXX_STANDARD 20) +set_target_properties(IPCTests_Preview_Tests PROPERTIES CXX_STANDARD 20) +set_target_properties(IPCTests_Non_Preview_Tests PROPERTIES CXX_STANDARD 20) diff --git a/sycl/unittests/Extensions/InterProcessCommunication/Memory.cpp b/sycl/unittests/Extensions/InterProcessCommunication/Memory.cpp index 96a26b43dace9..afcb5d80c4e6d 100644 --- a/sycl/unittests/Extensions/InterProcessCommunication/Memory.cpp +++ b/sycl/unittests/Extensions/InterProcessCommunication/Memory.cpp @@ -112,8 +112,10 @@ TEST_F(IPCTests, IPCGetPutImplicit) { syclexp::ipc_memory::handle IPCMemHandle = syclexp::ipc_memory::get(DummyPtr, Ctxt); syclexp::ipc_memory::handle_data_t IPCMemHandleData = IPCMemHandle.data(); - EXPECT_EQ(IPCMemHandleData.size(), DummyHandleDataSize); - EXPECT_EQ(IPCMemHandleData.data(), DummyHandleData); + ASSERT_EQ(IPCMemHandleData.size(), DummyHandleDataSize); + EXPECT_EQ(std::memcmp(IPCMemHandleData.data(), DummyHandleData, + DummyHandleDataSize), + 0); // Creating the IPC memory from a pointer should only call "get". EXPECT_EQ(urIPCGetMemHandleExp_counter, 1); @@ -126,8 +128,10 @@ TEST_F(IPCTests, IPCGetPutExplicit) { syclexp::ipc_memory::handle IPCMemHandle = syclexp::ipc_memory::get(DummyPtr, Ctxt); syclexp::ipc_memory::handle_data_t IPCMemHandleData = IPCMemHandle.data(); - EXPECT_EQ(IPCMemHandleData.size(), DummyHandleDataSize); - EXPECT_EQ(IPCMemHandleData.data(), DummyHandleData); + ASSERT_EQ(IPCMemHandleData.size(), DummyHandleDataSize); + EXPECT_EQ(std::memcmp(IPCMemHandleData.data(), DummyHandleData, + DummyHandleDataSize), + 0); // Creating the IPC memory from a pointer should only call "get". EXPECT_EQ(urIPCGetMemHandleExp_counter, 1);