process.exit(1) for detect difference with diff command (#66)

Author: kazupon

src/commands/diff.ts

@@ -22,6 +22,8 @@ export const command = 'diff'
 export const aliases = 'df'
 export const describe = 'Diff locale messages between local and localization service'
 
+class DiffError extends Error {}
+
 export const builder = (args: Argv): Argv<DiffOptions> => {
   return args
     .option('provider', {
@@ -60,6 +62,19 @@ export const builder = (args: Argv): Argv<DiffOptions> => {
       alias: 'n',
       describe: 'option for the locale messages structure, you can specify the option, if you hope to normalize for the provider.'
     })
+    .fail((msg, err) => {
+      if (msg) {
+        console.error(msg)
+        process.exit(1)
+      } else {
+        if (err instanceof DiffError) {
+          console.warn(err.message)
+          process.exit(1)
+        } else {
+          if (err) throw err
+        }
+      }
+    })
 }
 
 export const handler = async (args: Arguments<DiffOptions>): Promise<unknown> => {
@@ -90,15 +105,15 @@ export const handler = async (args: Arguments<DiffOptions>): Promise<unknown> =>
     return
   }
 
-  try {
-    const provider = ProviderFactory(conf)
-    const locales = Object.keys(localeMessages) as Locale[]
-    const serviceMessages = await provider.pull({ locales, dryRun: false, normalize, format })
-    console.log(diffString(localeMessages, serviceMessages))
-  } catch (e) {
-    // TODO: should refactor console message
-    console.error('diff fail', e)
-  }
+  const provider = ProviderFactory(conf)
+  const locales = Object.keys(localeMessages) as Locale[]
+  const serviceMessages = await provider.pull({ locales, dryRun: false, normalize, format })
+  const ret = diffString(localeMessages, serviceMessages)
+  console.log(ret)
+
+  return !ret
+    ? Promise.reject(new DiffError('There are differences!'))
+    : Promise.resolve('No difference!')
 }
 
 export default {

src/commands/status.ts

@@ -49,7 +49,6 @@ export const builder = (args: Argv): Argv<StatusOptions> => {
 }
 
 export const handler = async (args: Arguments<StatusOptions>): Promise<unknown> => {
-  // try {
   const { provider, conf, locales } = args
   debug(`status args: provider=${provider}, conf=${conf}, locales=${locales}`)
   const status = await getTranslationStatus({ provider, conf, locales })

test/commands/diff.test.ts

@@ -25,19 +25,22 @@ import L10nOmitServiceProvider from '@scope/l10n-omit-service-provider' // eslin
 const PROCESS_CWD_TARGET_PATH = path.resolve(__dirname)
 
 let orgCwd // for process.cwd mock
+let orgExit // for process.exit mock
 let spyLog
 let spyError
 beforeEach(() => {
   spyLog = jest.spyOn(global.console, 'log')
   spyError = jest.spyOn(global.console, 'error')
   orgCwd = process.cwd
   process.cwd = jest.fn(() => PROCESS_CWD_TARGET_PATH) // mock: process.cwd
+  process.exit = jest.fn((code => { return 'exit!' as never })) // mock: process.exit
 })
 
 afterEach(() => {
   spyError.mockRestore()
   spyLog.mockRestore()
   jest.clearAllMocks()
+  process.exit = orgExit
   process.cwd = orgCwd
 })