refactor: change error severity from none to ignore

Author: Artur-Wisniewski

README.md

@@ -238,7 +238,7 @@ custom_lint:
     my_lint_rule: error
 ```
 
-The available severity levels are: `error`, `warning`, `info`, and `none`.
+The available severity levels are: `error`, `warning`, `info`, and `ignore`.
 
 ### Obtaining the list of lints in the CI
 

packages/custom_lint/test/analysis_options_test.dart

@@ -121,7 +121,7 @@ Analyzing...
       expect(process.exitCode, 1);
     });
 
-    test('correctly applies none severity from analysis_options.yaml',
+    test('correctly applies ignore severity from analysis_options.yaml',
         () async {
       final plugin = createTestPlugin();
 
@@ -130,7 +130,7 @@ Analyzing...
         analysisOptions: '''
 custom_lint:
   errors:
-    test_lint: none
+    test_lint: ignore
 ''',
       );
 

packages/custom_lint_builder/lib/src/custom_analyzer_converter.dart

@@ -84,7 +84,7 @@ class CustomAnalyzerConverter {
       // Config severities override processor severities
       final severity = configSeverity ?? processor?.severity;
 
-      // Errors with none severity are filtered out.
+      // Errors with ignore severity are filtered out.
       if (severity == analyzer.ErrorSeverity.NONE) {
         continue;
       }

packages/custom_lint_core/lib/src/configs.dart

@@ -118,7 +118,7 @@ class CustomLintConfigs {
           'info' => ErrorSeverity.INFO,
           'warning' => ErrorSeverity.WARNING,
           'error' => ErrorSeverity.ERROR,
-          'none' => ErrorSeverity.NONE,
+          'ignore' => ErrorSeverity.NONE,
           _ => throw UnsupportedError(
               'Unsupported severity ${entry.value} for key: ${entry.key}',
             ),

packages/custom_lint_core/test/configs_test.dart

@@ -366,7 +366,7 @@ custom_lint:
     rule_name_1: error
     rule_name_2: warning
     rule_name_3: info
-    rule_name_4: none
+    rule_name_4: ignore
 ''');
       final configs = CustomLintConfigs.parse(analysisOptions, packageConfig);
 
@@ -387,11 +387,10 @@ custom_lint:
       expect(
         () => CustomLintConfigs.parse(analysisOptions, packageConfig),
         throwsA(
-          isArgumentError.having(
+          isA<UnsupportedError>().having(
             (e) => e.message,
             'message',
-            'Provided error severity: invalid_severity specified for key: rule_name_1 is not valid. '
-                'Valid error severities are: none, info, warning, error',
+            'Unsupported severity invalid_severity for key: rule_name_1',
           ),
         ),
       );