test: correctly fail on errors in test suite

Author: mikehardy

test.sh

@@ -1,12 +1,5 @@
 #!/bin/bash
-# set -e
-
-EXPECTED='(x): number => 123\n'
-ACTUAL=$(echo '(  \n x ) : number  =>   123  ' | /usr/bin/env node index.js -assume-filename a.js)
-if [[ "$ACTUAL" = "$EXPECTED" ]]; then
-  echo "[FAIL] Expected $EXPECTED, got $ACTUAL" >&2
-  exit 1
-fi
+set -e
 
 # Make sure we can run on relative an absolute paths (set -e checks for errors).
 /usr/bin/env node index.js index.js >/dev/null
@@ -21,7 +14,7 @@ EXPECTED_GLOB_STRING="ran google-java-format on 2 files" # somewhere in there
 
 (
   cd "$PWD"/testproject
-  yarn > /dev/null # Should give us a local clang-format, version doesn't really matter.
+  yarn > /dev/null # Should give us a local google-java-format, version doesn't really matter.
   VERSION=$(/usr/bin/env node "$FULL_SCRIPT_PATH" -version)
   if [[ $VERSION != *"$EXPECTED_VERSION_STRING"* ]]; then
     echo "[FAIL] Expected string containing $EXPECTED_VERSION_STRING, got $VERSION" >&2
@@ -49,6 +42,7 @@ fi
 echo "[PASS] glob argument resolution" >&2
 
 echo "(The next output lines will be an expected error, as we test error codes)"
+set +e
 eval "/usr/bin/env node $FULL_SCRIPT_PATH --set-exit-if-changed -n --glob=testproject/**/*.java"
 if [ "$?" != 1 ]; then
   echo "[FAIL] Expected return status to be 1, got $?" >&2