Skip to content

Conversation

@rwiltz
Copy link
Contributor

@rwiltz rwiltz commented Nov 26, 2025

Description

An Isaac Sim import path changed in Isaac Lab which broke a fragile import in xr_anchor_utils. This change fixed the import.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@rwiltz rwiltz requested a review from kellyguo11 November 26, 2025 01:35
@github-actions github-actions bot added bug Something isn't working isaac-mimic Related to Isaac Mimic team isaac-lab Related to Isaac Lab team labels Nov 26, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 26, 2025

Greptile Overview

Greptile Summary

This PR fixes a broken import in Isaac Lab's XR anchor utilities module that occurred due to an Isaac Sim import path change. The fix updates the import statement for get_current_stage_id from accessing it through the broader isaaclab.sim module to directly importing it from its specific location at isaaclab.sim.utils.stage. The change makes the import more explicit and robust, following better Python practices by importing exactly what's needed rather than relying on indirect module access.

The fix includes the necessary version bump from 0.48.6 to 0.48.7 and corresponding changelog entry, following the project's semantic versioning conventions for bug fixes. This change integrates well with Isaac Lab's module structure and addresses the fragility that occurred when external dependencies changed their internal organization.

Important Files Changed

Filename Score Overview
source/isaaclab/config/extension.toml 5/5 Version bump from 0.48.6to0.48.7 following semantic versioning for bug fix
source/isaaclab/docs/CHANGELOG.rst 5/5 Added changelog entry documenting the import path fix for stage context propagation
source/isaaclab/isaaclab/devices/openxr/xr_anchor_utils.py 5/5 Fixed broken import by directly importing get_current_stage_id from specific module path

Confidence score: 5/5

  • This PR is safe to merge with minimal risk of breaking functionality
  • Score reflects a straightforward import fix with proper documentation and versioning
  • No files require special attention as all changes are clean and well-documented

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@kellyguo11 kellyguo11 changed the title Import the proper module for get_stage_id Imports the proper module for get_stage_id Nov 26, 2025
@kellyguo11 kellyguo11 merged commit 26083c7 into isaac-sim:main Nov 26, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team isaac-mimic Related to Isaac Mimic team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants