Test fast access properties

Author: Baris Sencan

ManualLayoutTests/FastAccessTests.swift

@@ -12,85 +12,218 @@ import ManualLayout
 
 class FastAccessTests: XCTestCase {
   let view = UIView(frame: CGRectZero)
+  let defaultFrame = CGRect(x: 1, y: 3, width: 6, height: 8)
 
   override func setUp() {
-    view.frame = CGRectZero
+    view.frame = defaultFrame
   }
 
   func testOrigin() {
-    let origin = CGPoint(x: 10, y: 10)
-    view.origin = origin
-    XCTAssertEqual(view.frame.origin, origin, "origin changes should modify frame origin")
-    XCTAssertEqual(view.frame.size, CGSizeZero, "origin changes should not modify frame size")
+    let newOrigin = CGPoint(x: 10, y: 10)
+    view.origin = newOrigin
+    XCTAssertEqual(
+      view.frame.origin,
+      newOrigin,
+      "origin changes should modify frame origin")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "origin changes should not modify frame size")
   }
 
   func testX() {
     view.x = 10
-    XCTAssertEqual(view.frame.origin, CGPoint(x: 10, y: 0), "x changes should just modify frame x")
-    XCTAssertEqual(view.frame.size, CGSizeZero, "x changes should not modify frame size")
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: 10, y: defaultFrame.origin.y),
+      "x changes should just modify frame x")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "x changes should not modify frame size")
   }
 
   func testY() {
     view.y = 10
-    XCTAssertEqual(view.frame.origin, CGPoint(x: 0, y: 10), "y changes should just modify frame y")
-    XCTAssertEqual(view.frame.size, CGSizeZero, "y changes should not modify frame size")
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: defaultFrame.origin.x, y: 10),
+      "y changes should just modify frame y")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "y changes should not modify frame size")
   }
 
   func testCenter() {
-
+    view.layer.center = CGPoint(x: 10, y: 10)
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: 7, y: 6),
+      "center changes should center frame")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "center changes should not modify frame size")
   }
 
   func testCenterX() {
-
+    view.centerX = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: 7, y: defaultFrame.origin.y),
+      "centerX changes should center frame")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "centerX changes should not modify frame size")
   }
 
   func testCenterY() {
-    
+    view.centerY = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: defaultFrame.origin.x, y: 6),
+      "centerY changes should center frame")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "centerY changes should not modify frame size")
   }
 
   func testSize() {
-
+    view.size = CGSizeZero
+    XCTAssertEqual(
+      view.frame.origin,
+      defaultFrame.origin,
+      "size changes should not modify frame origin")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSizeZero,
+      "size changes should modify frame size")
   }
 
   func testWidth() {
-
+    view.width = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      defaultFrame.origin,
+      "width changes should not modify frame origin")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSize(width: 10, height: defaultFrame.size.height),
+      "width changes should just modify frame width")
   }
 
   func testHeight() {
-    
+    view.height = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      defaultFrame.origin,
+      "height changes should not modify frame origin")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSize(width: defaultFrame.size.width, height: 10),
+      "height changes should just modify frame height")
   }
 
   func testTop() {
     view.top = 10
-    XCTAssertEqual(view.frame.origin, CGPoint(x: 0, y: 10), "top changes should just modify frame y")
-    XCTAssertEqual(view.frame.size, CGSizeZero, "top changes should not modify frame size")
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: defaultFrame.origin.x, y: 10),
+      "top changes should just modify frame y")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "top changes should not modify frame size")
   }
 
   func testRight() {
-
+    view.right = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: 10 - defaultFrame.size.width, y: defaultFrame.origin.y),
+      "right changes should just modify frame x")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "right changes should not modify frame size")
   }
 
   func testBottom() {
-
+    view.bottom = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: defaultFrame.origin.x, y: 10 - defaultFrame.size.height),
+      "bottom changes should just modify frame y")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "bottom changes should not modify frame size")
   }
 
   func testLeft() {
-
+    view.left = 10
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: 10, y: defaultFrame.origin.y),
+      "left changes should just modify frame x")
+    XCTAssertEqual(
+      view.frame.size,
+      defaultFrame.size,
+      "left changes should not modify frame size")
   }
 
   func testTop2() {
-
+    view.top2 = 5
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: defaultFrame.origin.x, y: 5),
+      "top2 changes without a swap should just modify frame y")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSize(width: defaultFrame.size.width, height: 6),
+      "top2 changes without a swap should modify frame size")
+    // TODO: Test swap behavior.
   }
 
   func testRight2() {
-
+    view.right2 = 5
+    XCTAssertEqual(
+      view.frame.origin,
+      defaultFrame.origin,
+      "right2 changes without a swap should not modify frame origin")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSize(width: 4, height: defaultFrame.size.height),
+      "right2 changes without a swap should modify frame size")
+    // TODO: Test swap behavior.
   }
 
   func testBottom2() {
-
+    view.bottom2 = 5
+    XCTAssertEqual(
+      view.frame.origin,
+      defaultFrame.origin,
+      "bottom2 changes without a swap should not modify frame origin")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSize(width: defaultFrame.size.width, height: 2),
+      "bottom2 changes without a swap should modify frame size")
+    // TODO: Test swap behavior.
   }
 
   func testLeft2() {
-    
+    view.left2 = 5
+    XCTAssertEqual(
+      view.frame.origin,
+      CGPoint(x: 5, y: defaultFrame.origin.y),
+      "left2 changes without a swap should just modify frame x")
+    XCTAssertEqual(
+      view.frame.size,
+      CGSize(width: 2, height: defaultFrame.size.height),
+      "left2 changes without a swap should modify frame size")
+    // TODO: Test swap behavior.
   }
 }

ManualLayoutTests/ManualLayoutTests.swift

@@ -15,14 +15,14 @@ internal class ManualLayoutTests: XCTestCase {
   let rect = CGRect(x: 0, y: 0, width: 10, height: 10)
 
   func testGetOriginForCenteringRect() {
-    let origin = ManualLayout.getOriginForCenteringRect(rect, inRect: otherRect)
-    XCTAssertEqual(origin, CGPoint(x: 55, y: 65), "origin should be at (55, 65)")
+    let o = ManualLayout.getOriginForCenteringRect(rect, inRect: otherRect)
+    XCTAssertEqual(o, CGPoint(x: 55, y: 65), "o should equal center point")
   }
 
   func testGetPositionForCenteringRect() {
-    let positionX = ManualLayout.getPositionForCenteringRect(rect, dimension: .X, inRect: otherRect)
-    XCTAssert(positionX == 55, "x position should be 55")
-    let positionY = ManualLayout.getPositionForCenteringRect(rect, dimension: .Y, inRect: otherRect)
-    XCTAssert(positionY == 65, "y position should be 65")
+    let x = ManualLayout.getPositionForCenteringRect(rect, dimension: .X, inRect: otherRect)
+    XCTAssert(x == 55, "x should be in center")
+    let y = ManualLayout.getPositionForCenteringRect(rect, dimension: .Y, inRect: otherRect)
+    XCTAssert(y == 65, "y should be in center")
   }
 }