Skip to content

Commit 1782890

Browse files
authored
Merge pull request #326 from iteratec/bugfix/timeseriesCharSelection
Fixes #319 - Time series chart selection of points
2 parents 4a85f51 + 9a14d43 commit 1782890

File tree

8 files changed

+347
-345
lines changed

8 files changed

+347
-345
lines changed

frontend/src/app/modules/time-series/components/time-series-line-chart/time-series-line-chart.component.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
<div class="time-series-line-chart-container">
1+
<div id="time-series-line-chart-container">
2+
<osm-spinner [spinnerId]="'time-series-line-chart-spinner'"></osm-spinner>
3+
24
<div class="card">
35
<svg #svg/>
46
</div>

frontend/src/app/modules/time-series/components/time-series-line-chart/time-series-line-chart.component.scss

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
@import "../../../../../styles/colors";
22

33
osm-time-series-line-chart {
4-
visibility: hidden;
4+
#time-series-line-chart-container {
5+
position: relative;
6+
width: 100%;
7+
}
58

69
#marker-tooltip {
710
position: absolute;
@@ -67,7 +70,7 @@ osm-time-series-line-chart {
6770
.summary-label {
6871
font-weight: normal;
6972
}
70-
73+
7174
.legend-entry {
7275
cursor: pointer;
7376
}

frontend/src/app/modules/time-series/components/time-series-line-chart/time-series-line-chart.component.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
import {EventResultData} from '../../models/event-result-data.model';
1414
import {LineChartService} from '../../services/line-chart.service';
1515
import {NgxSmartModalService} from "ngx-smart-modal";
16+
import {SpinnerService} from "../../../shared/services/spinner.service";
1617

1718

1819
@Component({
@@ -32,7 +33,8 @@ export class TimeSeriesLineChartComponent implements AfterContentInit, OnChanges
3233
private _resizeTimeoutId: number;
3334

3435
constructor(private lineChartService: LineChartService,
35-
private ngxSmartModalService: NgxSmartModalService) {
36+
private ngxSmartModalService: NgxSmartModalService,
37+
private spinnerService: SpinnerService) {
3638
}
3739

3840
ngAfterContentInit(): void {
@@ -58,6 +60,13 @@ export class TimeSeriesLineChartComponent implements AfterContentInit, OnChanges
5860
}
5961

6062
redraw() {
63+
if(this.timeSeriesResults == null) {
64+
this.spinnerService.showSpinner("time-series-line-chart-spinner");
65+
return;
66+
}
67+
68+
this.spinnerService.hideSpinner("time-series-line-chart-spinner");
69+
6170
this.lineChartService.setLegendData(this.timeSeriesResults);
6271
this.lineChartService.drawLineChart(this.timeSeriesResults);
6372
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import {TimeSeriesPoint} from "./time-series-point.model";
2+
3+
export default class ContextMenuPosition {
4+
//if divider is set on true, the other fields are ignored
5+
divider?: boolean = false;
6+
7+
title?: string;
8+
icon?: string;
9+
visible?: (d: TimeSeriesPoint, i: number, elem) => boolean;
10+
action?: (d: TimeSeriesPoint, i: number, elem) => void;
11+
}

0 commit comments

Comments
 (0)