Skip to content

Commit 4cdec35

Browse files
authored
drop safety (#365)
GitHub has dependency alerts and dependency security updates that can replace `safety`. For the past few months, safety has been raising vulnerability errors for `pip` and now `jinja2`. The latter is a dependency of `safety` itself, and both CVEs are disputed. Which is breaking CI for us.
1 parent f9bb897 commit 4cdec35

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

.github/workflows/tests.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,11 @@ jobs:
4040
pip --version
4141
nox --version
4242
43-
- name: Lint code and check dependencies
44-
continue-on-error: ${{ matrix.nox_pyv == '3.11' }}
45-
run: nox -s lint safety --verbose
43+
- name: Lint code
44+
run: nox -s lint
4645

4746
- name: Run tests
48-
run: nox -s tests-${{ matrix.nox_pyv || matrix.pyv }} -- --slow --cov-report=xml
47+
run: nox -s tests-${{ matrix.pyv }} -- --slow --cov-report=xml
4948

5049
- name: Upload coverage report
5150
uses: codecov/codecov-action@v3.1.0

noxfile.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,6 @@ def lint(session: nox.Session) -> None:
3232
session.run("python", "-m", "mypy")
3333

3434

35-
@nox.session
36-
def safety(session: nox.Session) -> None:
37-
"""Scan dependencies for insecure packages."""
38-
session.install(".[dev]")
39-
session.install("safety")
40-
session.run("safety", "check", "--full-report", "--ignore=67599")
41-
42-
4335
@nox.session
4436
def build(session: nox.Session) -> None:
4537
session.install("build", "setuptools", "twine")

0 commit comments

Comments
 (0)