Skip to content

Commit dcc8edc

Browse files
committed
Add tests for fixed empty rows elimination logic
DEVSIX-6095
1 parent 92a8fa2 commit dcc8edc

File tree

6 files changed

+852
-3
lines changed

6 files changed

+852
-3
lines changed

src/test/java/com/itextpdf/html2pdf/element/TableTest.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,6 @@ public void cellWithRowspanShouldBeConsideredWhileCalculatingColumnWidths() thro
537537

538538

539539
@Test
540-
// TODO DEVSIX-5290 change cmp after the correction
541540
public void emptyTrRowspanBorderCollapsingTest() throws IOException, InterruptedException {
542541
runTest("emptyTrRowspanBorderCollapsing");
543542
}
@@ -549,8 +548,6 @@ public void emptyTdTest() throws IOException, InterruptedException {
549548
}
550549

551550
@Test
552-
@LogMessages(messages = {@LogMessage(messageTemplate =
553-
IoLogMessageConstant.UNEXPECTED_BEHAVIOUR_DURING_TABLE_ROW_COLLAPSING, count = 2)})
554551
public void emptyTrTest() throws IOException, InterruptedException {
555552
runTest("emptyTr");
556553
}
@@ -621,6 +618,18 @@ public void inlineWithInlineBlockAsTdChildWrappedTest() throws IOException, Inte
621618
runTest("inlineWithInlineBlockAsTdChildWrapped");
622619
}
623620

621+
@Test
622+
@LogMessages(messages = {@LogMessage(messageTemplate = IoLogMessageConstant.LAST_ROW_IS_NOT_COMPLETE, count = 2)})
623+
public void emptyRowEliminationTest1() throws IOException, InterruptedException {
624+
runTest("emptyRowElimination1");
625+
}
626+
627+
@Test
628+
@LogMessages(messages = {@LogMessage(messageTemplate = IoLogMessageConstant.LAST_ROW_IS_NOT_COMPLETE)})
629+
public void emptyRowEliminationTest2() throws IOException, InterruptedException {
630+
runTest("emptyRowElimination2");
631+
}
632+
624633
private void runTest(String testName) throws IOException, InterruptedException {
625634
runTest(testName, false);
626635
}

0 commit comments

Comments
 (0)