refactor

Author: j5ik2o

domain/src/main/java/com/github/j5ik2o/ddd_example/domain/BankAccount.java

@@ -2,13 +2,16 @@
 
 import com.github.j5ik2o.ddd_eaxmple.utils.IdGenerator;
 import com.google.common.collect.Lists;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
 import lombok.NonNull;
 import lombok.Value;
 
 import java.math.BigDecimal;
 import java.util.List;
 
 @Value
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
 public final class BankAccount {
 
     @NonNull

domain/src/main/java/com/github/j5ik2o/ddd_example/domain/BankAccountEvent.java

@@ -1,11 +1,14 @@
 package com.github.j5ik2o.ddd_example.domain;
 
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
 import lombok.NonNull;
 import lombok.Value;
 
 import java.time.ZonedDateTime;
 
 @Value
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
 public final class BankAccountEvent {
     @NonNull
     private Long id;

domain/src/main/java/com/github/j5ik2o/ddd_example/domain/BankAccountService.java

@@ -1,5 +1,7 @@
 package com.github.j5ik2o.ddd_example.domain;
 
+import lombok.NonNull;
+import lombok.RequiredArgsConstructor;
 import lombok.Value;
 
 public final class BankAccountService {
@@ -8,23 +10,26 @@ public final class BankAccountService {
      * 口座間送金後の状態を表す値オブジェクト。
      */
     @Value
+    @RequiredArgsConstructor(staticName = "of")
     public static class TransferResult {
+        @NonNull
         private BankAccount to;
+        @NonNull
         private BankAccount from;
     }
 
     /**
      * 二つの口座間でお金を移動する。
      *
-     * @param to 移動先の口座
-     * @param from 移動元の口座
+     * @param to    移動先の口座
+     * @param from  移動元の口座
      * @param money お金
      * @return 移動後の結果
      */
     public static TransferResult transfer(BankAccount to, BankAccount from, Money money) {
         BankAccount updatedFrom = from.withdrawTo(to, money);
         BankAccount updatedTo = to.depositFrom(from, money);
-        return new TransferResult(updatedTo, updatedFrom);
+        return TransferResult.of(updatedTo, updatedFrom);
     }
 
 }

domain/src/main/java/com/github/j5ik2o/ddd_example/stepbase/BankAccountService.java

@@ -2,6 +2,8 @@
 
 import com.github.j5ik2o.ddd_eaxmple.utils.IdGenerator;
 import com.google.common.collect.Lists;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
 import lombok.Data;
 
 import java.math.BigDecimal;

domain/src/test/java/com/github/j5ik2o/ddd_example/domain/BankAccountServiceTest.java

@@ -3,6 +3,8 @@
 import com.github.j5ik2o.ddd_eaxmple.utils.IdGenerator;
 import org.junit.Test;
 
+import static org.junit.Assert.fail;
+
 public class BankAccountServiceTest {
 
     @Test
@@ -33,13 +35,12 @@ public void transfer2() throws Exception {
         System.out.println("bankAccount1 = " + bankAccount1.getBalance());
         System.out.println("bankAccount2 = " + bankAccount2.getBalance());
 
-        BankAccountService.TransferResult transferResult = BankAccountService.transfer(
-                bankAccount1,
-                bankAccount2,
-                Money.of(20000)
-        );
+        try {
+            BankAccountService.transfer(bankAccount1, bankAccount2, Money.of(20000));
+            fail("No error occurred!!!");
+        } catch (IllegalArgumentException ignored) {
+            ;
+        }
 
-        System.out.println("to = " + transferResult.getTo().getBalance());
-        System.out.println("from = " + transferResult.getFrom().getBalance());
     }
 }

domain/src/test/java/com/github/j5ik2o/ddd_example/domain/BankAccountTest.java

@@ -7,7 +7,7 @@ public class BankAccountTest {
 
     @Test
     public void test() {
-        BankAccount bankAccount = new BankAccount(1L, ImmutableList.of()).depositCash(Money.of(10000));
+        BankAccount bankAccount = BankAccount.of(1L).depositCash(Money.of(10000));
         System.out.println(bankAccount.getBalance());
     }