chore: consolidate download service

Author: namchuai

engine/CMakeLists.txt

@@ -78,6 +78,7 @@ find_package(LibArchive REQUIRED)
 find_package(tabulate CONFIG REQUIRED)
 find_package(CURL REQUIRED)
 find_package(SQLiteCpp REQUIRED)
+find_package(eventpp CONFIG REQUIRED)
 
 add_executable(${TARGET_NAME} main.cc
     ${CMAKE_CURRENT_SOURCE_DIR}/utils/cpuid/cpu_info.cc
@@ -94,6 +95,7 @@ target_link_libraries(${TARGET_NAME} PRIVATE CURL::libcurl)
 target_link_libraries(${TARGET_NAME} PRIVATE JsonCpp::JsonCpp Drogon::Drogon OpenSSL::SSL OpenSSL::Crypto yaml-cpp::yaml-cpp
   ${CMAKE_THREAD_LIBS_INIT})
 target_link_libraries(${TARGET_NAME} PRIVATE SQLiteCpp)
+target_link_libraries(${TARGET_NAME} PRIVATE eventpp::eventpp)
 
 # ##############################################################################
 

engine/commands/chat_completion_cmd.cc

@@ -1,13 +1,11 @@
 #include "chat_completion_cmd.h"
-#include "httplib.h"
-
 #include "config/yaml_config.h"
 #include "cortex_upd_cmd.h"
 #include "database/models.h"
+#include "httplib.h"
 #include "model_status_cmd.h"
-#include "run_cmd.h"
 #include "server_start_cmd.h"
-#include "trantor/utils/Logger.h"
+#include "utils/engine_constants.h"
 #include "utils/logging_utils.h"
 
 namespace commands {
@@ -79,7 +77,8 @@ void ChatCompletionCmd::Exec(const std::string& host, int port,
   // Only check if llamacpp engine
   if ((mc.engine.find(kLlamaEngine) != std::string::npos ||
        mc.engine.find(kLlamaRepo) != std::string::npos) &&
-      !commands::ModelStatusCmd().IsLoaded(host, port, model_handle)) {
+      !commands::ModelStatusCmd(model_service_)
+           .IsLoaded(host, port, model_handle)) {
     CLI_LOG("Model is not loaded yet!");
     return;
   }
@@ -155,4 +154,4 @@ void ChatCompletionCmd::Exec(const std::string& host, int port,
   }
 }
 
-};  // namespace commands
+};  // namespace commands

engine/commands/chat_completion_cmd.h

@@ -1,18 +1,23 @@
 #pragma once
+
 #include <string>
 #include <vector>
 #include "config/model_config.h"
-#include "nlohmann/json.hpp"
+#include "services/model_service.h"
 
 namespace commands {
 class ChatCompletionCmd {
  public:
+  explicit ChatCompletionCmd(const ModelService& model_service)
+      : model_service_{model_service} {};
+
   void Exec(const std::string& host, int port, const std::string& model_handle,
             std::string msg);
   void Exec(const std::string& host, int port, const std::string& model_handle,
             const config::ModelConfig& mc, std::string msg);
 
  private:
   std::vector<Json::Value> histories_;
+  ModelService model_service_;
 };
-}  // namespace commands
+}  // namespace commands

engine/commands/cortex_upd_cmd.cc

@@ -395,7 +395,7 @@ bool CortexUpdCmd::HandleGithubRelease(const nlohmann::json& assets,
                                           .localPath = local_path,
                                       }}}};
 
-      DownloadService().AddDownloadTask(
+      auto result = DownloadService().AddDownloadTask(
           download_task, [](const DownloadTask& finishedTask) {
             // try to unzip the downloaded file
             CTL_INF("Downloaded engine path: "
@@ -410,6 +410,9 @@ bool CortexUpdCmd::HandleGithubRelease(const nlohmann::json& assets,
 
             CTL_INF("Finished!");
           });
+      if (result.has_error()) {
+        CTL_ERR("Failed to download: " << result.error());
+      }
       break;
     }
   }
@@ -457,7 +460,7 @@ bool CortexUpdCmd::GetNightly(const std::string& v) {
                        .localPath = localPath,
                    }}};
 
-  auto res = DownloadService().AddDownloadTask(
+  auto result = DownloadService().AddDownloadTask(
       download_task, [](const DownloadTask& finishedTask) {
         // try to unzip the downloaded file
         CTL_INF("Downloaded engine path: "
@@ -471,9 +474,8 @@ bool CortexUpdCmd::GetNightly(const std::string& v) {
 
         CTL_INF("Finished!");
       });
-
-  if (res.has_error()) {
-    CLI_LOG("Download failed!");
+  if (result.has_error()) {
+    CTL_ERR("Failed to download: " << result.error());
     return false;
   }
 

engine/commands/engine_get_cmd.h

@@ -5,7 +5,8 @@
 namespace commands {
 class EngineGetCmd {
  public:
-  explicit EngineGetCmd() : engine_service_{EngineService()} {};
+  explicit EngineGetCmd()
+      : engine_service_{EngineService(std::make_shared<DownloadService>())} {};
 
   void Exec(const std::string& engineName) const;
 

engine/commands/engine_install_cmd.h

@@ -7,7 +7,8 @@ namespace commands {
 
 class EngineInstallCmd {
  public:
-  explicit EngineInstallCmd() : engine_service_{EngineService()} {};
+  explicit EngineInstallCmd()
+      : engine_service_{EngineService(std::make_shared<DownloadService>())} {};
 
   void Exec(const std::string& engine, const std::string& version = "latest",
             const std::string& src = "");

engine/commands/engine_list_cmd.cc

@@ -1,12 +1,10 @@
 #include "engine_list_cmd.h"
 #include <tabulate/table.hpp>
-#include "services/engine_service.h"
 
 namespace commands {
 
 bool EngineListCmd::Exec() {
-  auto engine_service = EngineService();
-  auto status_list = engine_service.GetEngineInfoList();
+  auto status_list = engine_service_.GetEngineInfoList();
 
   tabulate::Table table;
   table.add_row(

engine/commands/engine_list_cmd.h

@@ -1,9 +1,17 @@
 #pragma once
 
+#include "services/engine_service.h"
+
 namespace commands {
 class EngineListCmd {
  public:
+  explicit EngineListCmd()
+      : engine_service_{EngineService(std::make_shared<DownloadService>())} {};
+
   bool Exec();
+
+ private:
+  EngineService engine_service_;
 };
 
 }  // namespace commands

engine/commands/engine_uninstall_cmd.h

@@ -1,12 +1,14 @@
 #pragma once
 
+#include <memory>
 #include <string>
 #include "services/engine_service.h"
 
 namespace commands {
 class EngineUninstallCmd {
  public:
-  explicit EngineUninstallCmd() : engine_service_{EngineService()} {};
+  explicit EngineUninstallCmd()
+      : engine_service_{EngineService(std::make_shared<DownloadService>())} {};
 
   void Exec(const std::string& engine);
 

engine/commands/model_del_cmd.h

@@ -7,7 +7,8 @@ namespace commands {
 
 class ModelDelCmd {
  public:
-  explicit ModelDelCmd() : model_service_{ModelService()} {};
+  explicit ModelDelCmd()
+      : model_service_{ModelService(std::make_shared<DownloadService>())} {};
 
   void Exec(const std::string& model_handle);