Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit 4e7a8ab

Browse files
authored
Fix windows codesign must run on cmd (#723)
Co-authored-by: Hien To <tominhhien97@gmail.com>
1 parent 90136a4 commit 4e7a8ab

File tree

2 files changed

+31
-24
lines changed

2 files changed

+31
-24
lines changed

.github/workflows/cortex-cpp-build.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,19 @@ jobs:
224224
cd cortex-cpp
225225
make codesign CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}"
226226
227-
- name: Code Signing Windows
227+
- uses: nick-fields/retry@v3
228+
with:
229+
continue_on_error: true
230+
retry_wait_seconds: 10
231+
timeout_minutes: 10
232+
max_attempts: 3
233+
shell: cmd
234+
command: |
235+
cd cortex-cpp
236+
set PATH=%PATH%;%USERPROFILE%\.dotnet\tools
237+
make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}"
238+
name: Code Signing Windows
228239
if: runner.os == 'Windows'
229-
run: |
230-
cd cortex-cpp
231-
set PATH=%PATH%;%USERPROFILE%\.dotnet\tools
232-
make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}"
233-
234240

235241
- name: Package
236242
run: |

.github/workflows/nightly-build.yml

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -219,24 +219,25 @@ jobs:
219219
cd cortex-cpp
220220
make pre-package
221221
222-
# - name: Code Signing macOS
223-
# if: runner.os == 'macOS'
224-
# run: |
225-
# cd cortex-cpp
226-
# make codesign CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}"
227-
228-
# - uses: nick-fields/retry@v3
229-
# with:
230-
# continue_on_error: true
231-
# retry_wait_seconds: 10
232-
# timeout_minutes: 10
233-
# max_attempts: 3
234-
# command: |
235-
# cd cortex-cpp
236-
# set PATH=%PATH%;%USERPROFILE%\.dotnet\tools
237-
# make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}"
238-
# name: Code Signing Windows
239-
# if: runner.os == 'Windows'
222+
- name: Code Signing macOS
223+
if: runner.os == 'macOS'
224+
run: |
225+
cd cortex-cpp
226+
make codesign CODE_SIGN=true DEVELOPER_ID="${{ secrets.DEVELOPER_ID }}"
227+
228+
- uses: nick-fields/retry@v3
229+
with:
230+
continue_on_error: true
231+
retry_wait_seconds: 10
232+
timeout_minutes: 10
233+
max_attempts: 3
234+
shell: cmd
235+
command: |
236+
cd cortex-cpp
237+
set PATH=%PATH%;%USERPROFILE%\.dotnet\tools
238+
make codesign CODE_SIGN=true AZURE_KEY_VAULT_URI="${{ secrets.AZURE_KEY_VAULT_URI }}" AZURE_CLIENT_ID="${{ secrets.AZURE_CLIENT_ID }}" AZURE_TENANT_ID="${{ secrets.AZURE_TENANT_ID }}" AZURE_CLIENT_SECRET="${{ secrets.AZURE_CLIENT_SECRET }}" AZURE_CERT_NAME="${{ secrets.AZURE_CERT_NAME }}"
239+
name: Code Signing Windows
240+
if: runner.os == 'Windows'
240241

241242
- name: Package
242243
run: |

0 commit comments

Comments
 (0)