update comment

Author: namchuai

engine/controllers/events.h

@@ -3,6 +3,7 @@
 #include <drogon/PubSubService.h>
 #include <drogon/WebSocketController.h>
 #include <eventpp/eventqueue.h>
+#include <unordered_set>
 #include "common/download_event.h"
 #include "common/event.h"
 
@@ -40,5 +41,5 @@ class Events : public drogon::WebSocketController<Events, false> {
   void broadcast(const std::string& message);
 
   std::shared_ptr<EventQueue> event_queue_;
-  std::set<WebSocketConnectionPtr> connections_;
+  std::unordered_set<WebSocketConnectionPtr> connections_;
 };

engine/services/download_service.cc

@@ -190,7 +190,7 @@ cpp::result<bool, std::string> DownloadService::Download(
       CTL_INF("Existing file size: " << download_item.downloadUrl << " - "
                                      << download_item.localPath.string()
                                      << " - " << existing_file_size);
-      CTL_INF("Download item size: " << download_item.bytes.value());                               
+      CTL_INF("Download item size: " << download_item.bytes.value());
       auto missing_bytes = download_item.bytes.value() - existing_file_size;
       if (missing_bytes > 0 &&
           download_item.localPath.extension().string() != ".yaml" &&

engine/services/download_service.h

@@ -7,7 +7,6 @@
 #include <optional>
 #include <vector>
 #include "common/download_event.h"
-#include "utils/logging_utils.h"
 #include "utils/result.hpp"
 
 class DownloadService {
@@ -49,7 +48,7 @@ class DownloadService {
 
   curl_off_t GetLocalFileSize(const std::filesystem::path& path) const;
 
-  std::optional<std::shared_ptr<EventQueue>> event_queue_;
+  std::shared_ptr<EventQueue> event_queue_;
 
   std::vector<std::string> download_task_list_;
   std::unordered_map<std::string, DownloadTask> download_task_map_;
@@ -64,9 +63,8 @@ class DownloadService {
 
   static int ProgressCallback(void* ptr, double dltotal, double dlnow,
                               double ultotal, double ulnow) {
-    DownloadService* service = static_cast<DownloadService*>(ptr);
-    auto event_queue = service->event_queue_.value();
-    if (event_queue == nullptr) {
+    auto service = static_cast<DownloadService*>(ptr);
+    if (service->event_queue_ == nullptr) {
       return 0;
     }
 
@@ -87,7 +85,7 @@ class DownloadService {
       }
     }
 
-    event_queue->enqueue(
+    service->event_queue_->enqueue(
         "download-update",
         DownloadEvent{
             .type_ = cortex::event::DownloadEventType::DownloadUpdated,

engine/utils/event_processor.h

@@ -17,8 +17,8 @@ class EventProcessor {
       : event_queue_(std::move(queue)), running_(true) {
     thread_ = std::thread([this]() {
       while (running_) {
+        event_queue_->wait();
         event_queue_->process();
-        std::this_thread::sleep_for(std::chrono::milliseconds(1));
       }
     });
   }