arguments to URL in 'get_history' in fleetapi/fleetapi.py

[thompsonmark]

this:

        arg_start = f"start={start}&" if start else ""
        arg_end = f"end={end}&" if end else ""

should be:

        arg_start = f"start_date={start}&" if start else ""
        arg_end = f"end_date={end}&" if end else ""

reference:
/api/1/energy_sites/{energy_site_id}/calendar_history?kind=energy&start_date={start_date}&end_date={end_date}&period={period}&time_zone={time_zone}

source:
https://developer.tesla.com/docs/fleet-api/endpoints/energy

thanks for releasing pypowerall. saved me a ton of time.

-mark

p.s. also, it would be cool if it took a 'datetime' as the arguments but that is clearly "enhancement"

[jasonacox]

Nice! Thanks @thompsonmark - would yo ube interested in submitting a PR for this (bug fix and enhancement)? I would love for you to get credit.

[thompsonmark]

You're very kind. The bug report is intended as a courtesy to you because your library is useful. I've coded around the bug and am moving on. Thanks again.

[jasonacox]

Perfect! I've fixed both issues in the FleetAPI:

Changes made:
Fixed parameter names (the bug):

start= → start_date=
end = → end_date=

Now matches the official Tesla FleetAPI specification

Added datetime support (the enhancement):

from datetime import datetime, timedelta

# Using datetime objects (new enhancement)
start = datetime(2024, 5, 1)
end = datetime.now()
history = fleetapi.get_history(kind='energy', start=start, end=end)

# Using RFC3339 strings (still works)
history = fleetapi.get_history(
    kind='energy',
    start='2024-05-01T00:00:00-07:00',
    end='2024-05-01T23:59:59-07:00'
)