Skip to content

Commit e3af3fd

Browse files
committed
Sync with underscore-java.
1 parent 3a43803 commit e3af3fd

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

src/main/java/com/github/underscore/lodash/U.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2054,7 +2054,7 @@ public static String xmlToJson(String xml, Json.JsonStringBuilder.Step identStep
20542054
Object result = Xml.fromXml(xml);
20552055
if (result instanceof Map) {
20562056
return Json.toJson(mode == Mode.REPLACE_SELF_CLOSING_WITH_NULL ?
2057-
replaceSelfCloseWithNull((Map) result) : (Map) result, identStep);
2057+
replaceSelfClosingWithNull((Map) result) : (Map) result, identStep);
20582058
}
20592059
return Json.toJson((List) result, identStep);
20602060
}
@@ -2083,12 +2083,8 @@ public static String formatXml(String xml) {
20832083
return Xml.formatXml(xml);
20842084
}
20852085

2086-
public static Map<String, Object> removeMinusesAndConvertNumbers(Map<String, Object> inMap) {
2087-
return replaceKeys(inMap);
2088-
}
2089-
20902086
@SuppressWarnings("unchecked")
2091-
private static Map<String, Object> replaceKeys(Map<String, Object> map) {
2087+
public static Map<String, Object> removeMinusesAndConvertNumbers(Map<String, Object> map) {
20922088
Map<String, Object> outMap = newLinkedHashMap();
20932089
for (String key : map.keySet()) {
20942090
final String newKey;
@@ -2110,11 +2106,11 @@ private static Object makeObject(Object value) {
21102106
if (value instanceof List) {
21112107
List<Object> values = newArrayList();
21122108
for (Object item : (List) value) {
2113-
values.add(item instanceof Map ? replaceKeys((Map<String, Object>) item) : item);
2109+
values.add(item instanceof Map ? removeMinusesAndConvertNumbers((Map<String, Object>) item) : item);
21142110
}
21152111
result = values;
21162112
} else if (value instanceof Map) {
2117-
result = replaceKeys((Map<String, Object>) value);
2113+
result = removeMinusesAndConvertNumbers((Map<String, Object>) value);
21182114
} else {
21192115
String stringValue = String.valueOf(value);
21202116
result = stringValue.matches("^-?\\d*([.eE])?\\d+$") ? Xml.stringToNumber(stringValue) : value;
@@ -2123,7 +2119,7 @@ private static Object makeObject(Object value) {
21232119
}
21242120

21252121
@SuppressWarnings("unchecked")
2126-
static Map<String, Object> replaceSelfCloseWithNull(Map map) {
2122+
public static Map<String, Object> replaceSelfClosingWithNull(Map map) {
21272123
Map<String, Object> outMap = newLinkedHashMap();
21282124
for (Iterator it = map.entrySet().iterator(); it.hasNext(); ) {
21292125
Map.Entry entry = (Map.Entry) it.next();
@@ -2145,11 +2141,11 @@ private static Object makeObjectSelfClose(Object value) {
21452141
if (value instanceof List) {
21462142
List<Object> values = newArrayList();
21472143
for (Object item : (List) value) {
2148-
values.add(item instanceof Map ? replaceSelfCloseWithNull((Map) item) : item);
2144+
values.add(item instanceof Map ? replaceSelfClosingWithNull((Map) item) : item);
21492145
}
21502146
result = values;
21512147
} else if (value instanceof Map) {
2152-
result = replaceSelfCloseWithNull((Map) value);
2148+
result = replaceSelfClosingWithNull((Map) value);
21532149
} else {
21542150
result = value;
21552151
}

src/test/java/com/github/underscore/lodash/LodashTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -642,12 +642,12 @@ public void xmlToJson() {
642642
U.xmlToJson("<a><b/><b/></a>", U.Mode.REPLACE_SELF_CLOSING_WITH_NULL));
643643
Map<String, Object> map = U.newLinkedHashMap();
644644
map.put("-self-closing", "false");
645-
U.replaceSelfCloseWithNull(map);
645+
U.replaceSelfClosingWithNull(map);
646646
Map<String, Object> map2 = U.newLinkedHashMap();
647647
List<Object> list = U.newArrayList();
648648
list.add(U.newArrayList());
649649
map2.put("list", list);
650-
U.replaceSelfCloseWithNull(map2);
650+
U.replaceSelfClosingWithNull(map2);
651651
}
652652

653653
@Test

0 commit comments

Comments
 (0)