No need to contact controller just to get appID

Author: jglick

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java

@@ -195,11 +195,13 @@ private static final class AgentSide extends BaseStandardCredentials implements
 
         static final String SEP = "%%%";
 
+        private final String appID;
         private final String data;
         private transient Channel ch;
 
         AgentSide(GitHubAppCredentials onMaster) {
             super(onMaster.getScope(), onMaster.getId(), onMaster.getDescription());
+            appID = onMaster.appID;
             data = Secret.fromString(onMaster.appID + SEP + onMaster.privateKey.getPlainText() + SEP + onMaster.actualApiUri() + SEP + onMaster.owner).getEncryptedValue();
         }
 
@@ -210,11 +212,7 @@ private Object readResolve() {
 
         @Override
         public String getUsername() {
-            try {
-                return ch.call(new GetUsername(data));
-            } catch (IOException | InterruptedException x) {
-                throw new RuntimeException(x);
-            }
+            return appID;
         }
 
         @Override
@@ -226,21 +224,6 @@ public Secret getPassword() {
             }
         }
 
-        private static final class GetUsername extends SlaveToMasterCallable<String, RuntimeException> {
-
-            private final String data;
-
-            GetUsername(String data) {
-                this.data = data;
-            }
-
-            @Override
-            public String call() throws RuntimeException {
-                return Secret.fromString(data).getPlainText().split(SEP)[0];
-            }
-
-        }
-
         private static final class GetPassword extends SlaveToMasterCallable<String, RuntimeException> {
 
             private final String data;