find bugs fixes

Author: aaronwalker

src/main/java/org/jenkinsci/plugins/pipeline/github/trigger/GitHubEventSubscriber.java

@@ -1,5 +1,6 @@
 package org.jenkinsci.plugins.pipeline.github.trigger;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.Extension;
 import hudson.model.CauseAction;
 import hudson.model.Item;
@@ -193,6 +194,7 @@ private boolean triggerMatches(final IssueCommentTrigger trigger,
         return false;
     }
 
+    @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     private void handlePullRequestReview(final GHSubscriberEvent event) {
         // we only care about created or updated events
         switch (event.getType()) {
@@ -281,6 +283,7 @@ private void handlePullRequestReview(final GHSubscriberEvent event) {
         }
     }
 
+    @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
     private boolean triggerMatches(final PullRequestReviewTrigger trigger,
                                    final GHPullRequestReview review,
                                    final WorkflowJob job) {

src/main/java/org/jenkinsci/plugins/pipeline/github/trigger/PullRequestReviewCause.java

@@ -3,6 +3,8 @@
 import hudson.model.Cause;
 import org.jenkinsci.plugins.scriptsecurity.sandbox.whitelists.Whitelisted;
 
+import java.util.Arrays;
+
 /**
  * Represents the user who reviewed the PR that triggered the build.
  *
@@ -19,7 +21,7 @@ public PullRequestReviewCause(final String userLogin, final String state, final
     this.userLogin = userLogin;
     this.state = state;
     this.comment = comment;
-    this.reviewStates = reviewStates;
+    this.reviewStates =  Arrays.copyOf(reviewStates, reviewStates.length);
   }
 
   @Whitelisted
@@ -39,7 +41,7 @@ public String getState() {
 
   @Whitelisted
   public String[] getReviewStates() {
-      return reviewStates;
+       return Arrays.copyOf(reviewStates, reviewStates.length);
   }
 
   @Override

src/main/java/org/jenkinsci/plugins/pipeline/github/trigger/PullRequestReviewTrigger.java

@@ -43,12 +43,12 @@ public class PullRequestReviewTrigger  extends Trigger<WorkflowJob> {
   public PullRequestReviewTrigger() {}
 
   public String[] getReviewStates() {
-      return reviewStates;
+      return Arrays.copyOf(reviewStates, reviewStates.length);
   }
 
   @DataBoundSetter
   public void setReviewStates(@Nonnull final String [] reviewStates) {
-      this.reviewStates = reviewStates;
+      this.reviewStates = Arrays.copyOf(reviewStates, reviewStates.length);
   }
 
   @Override