Skip to content

Commit 8149119

Browse files
authored
fix(tests): resolve "middleware /w promise" case logical error
1 parent 2196e6c commit 8149119

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

__tests__/errorHandling.unit.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,12 @@ api.use(function(err,req,res,next) {
7272
});
7373

7474
// Add error with promise/delay
75-
api.use(function(err,req,res,next) {
75+
api.use(async function(err,req,res,next) {
7676
if (req.route === '/testErrorPromise') {
77-
let start = Date.now()
78-
delay(100).then((x) => {
79-
res.header('Content-Type','text/plain')
80-
res.send('This is a test error message: ' + req.testError1 + '/' + req.testError2)
81-
})
77+
await delay(100);
78+
79+
res.header('Content-Type','text/plain')
80+
res.send('This is a test error message: ' + req.testError1 + '/' + req.testError2)
8281
} else {
8382
next()
8483
}
@@ -246,7 +245,7 @@ describe('Error Handling Tests:', function() {
246245
it('Error Middleware w/ Promise', async function() {
247246
let _event = Object.assign({},event,{ path: '/testErrorPromise'})
248247
let result = await new Promise(r => api.run(_event,{},(e,res) => { r(res) }))
249-
expect(result).toEqual({ multiValueHeaders: { 'content-type': ['application/json'] }, statusCode: 500, body: JSON.stringify({error: 'This is a test error message'}), isBase64Encoded: false })
248+
expect(result).toEqual({ multiValueHeaders: { 'content-type': ['text/plain'] }, statusCode: 500, body: 'This is a test error message: 123/456', isBase64Encoded: false })
250249
}) // end it
251250

252251
it('Multiple error middlewares', async function() {

0 commit comments

Comments
 (0)