Skip to content

Conversation

@BElluu
Copy link

@BElluu BElluu commented Nov 2, 2024

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Before we always use "origin". Now I modified the operation to check the
remote for a given branch, and based on the remote name, a remote URL is
created.
@BElluu
Copy link
Author

BElluu commented Nov 27, 2025

Hi @stefanhaller. What do you think about this changes?

@stefanhaller
Copy link
Collaborator

I'm sorry, I never got around to looking at this, and then it fell through the cracks. (You don't have to wait a whole year to ping me in a case like this 😉)

Meanwhile we have another PR that does a similar thing (#4775), and your branch has the same problem as that one. See my comments there. The difference is that the other PR always uses the checked-out branch, whereas yours always uses the selected local branch; both is wrong, you need to use one or the other case by case (or the selected remote if we press o on a commit of a remote branch).

But the bigger problem for me is the shift-O feature, which I don't really understand. Changing code that affects this feature without understanding what exactly it does is a problem; see #4775 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported git service (after renaming remote name)

2 participants