From 9c84d0cbc3c2d0ee6fc8070fb7019e7df8dc2a00 Mon Sep 17 00:00:00 2001 From: jeparlefrancais Date: Fri, 22 Nov 2024 23:31:25 -0500 Subject: [PATCH 1/5] Add useNavigation hook --- src/init.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/src/init.lua b/src/init.lua index df7f826..2890ec2 100644 --- a/src/init.lua +++ b/src/init.lua @@ -14,6 +14,7 @@ return { withNavigation = require("./views/withNavigation"), withNavigationFocus = require("./views/withNavigationFocus"), + useNavigation = require("./views/useNavigation"), -- Navigators createRobloxStackNavigator = require("./navigators/createRobloxStackNavigator"), From 8fd78d5acea6f4d7d8ecb211608f2ba006f86534 Mon Sep 17 00:00:00 2001 From: jeparlefrancais Date: Fri, 22 Nov 2024 23:31:37 -0500 Subject: [PATCH 2/5] Enable test workflow --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9f480e4..aff3720 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -3,10 +3,10 @@ name: Tests "on": push: branches: - - main + - master pull_request: branches: - - main + - master jobs: test: From eaa4e5f4eb7847c0cc7bed432cd725d338269b55 Mon Sep 17 00:00:00 2001 From: jeparlefrancais Date: Fri, 22 Nov 2024 23:43:10 -0500 Subject: [PATCH 3/5] Fix selene warnings --- src/routers/_tests_/createConfigGetter.spec.lua | 2 -- src/routers/_tests_/pathToRegexp.spec.lua | 1 - 2 files changed, 3 deletions(-) diff --git a/src/routers/_tests_/createConfigGetter.spec.lua b/src/routers/_tests_/createConfigGetter.spec.lua index e5b3f9f..4307888 100644 --- a/src/routers/_tests_/createConfigGetter.spec.lua +++ b/src/routers/_tests_/createConfigGetter.spec.lua @@ -4,8 +4,6 @@ local React = require("@pkg/@jsdotlua/react") local JestGlobals = require("@pkg/@jsdotlua/jest-globals") local expect = JestGlobals.expect local it = JestGlobals.it -local describe = JestGlobals.describe -local beforeEach = JestGlobals.beforeEach local createConfigGetter = require("../createConfigGetter") diff --git a/src/routers/_tests_/pathToRegexp.spec.lua b/src/routers/_tests_/pathToRegexp.spec.lua index e0b1611..4ed799a 100644 --- a/src/routers/_tests_/pathToRegexp.spec.lua +++ b/src/routers/_tests_/pathToRegexp.spec.lua @@ -9,7 +9,6 @@ local JestGlobals = require("@pkg/@jsdotlua/jest-globals") local expect = JestGlobals.expect local it = JestGlobals.it local describe = JestGlobals.describe -local beforeEach = JestGlobals.beforeEach local pathToRegexp = require("../pathToRegexp") local undefined = {} From d68fa568ec874bf403ed1aeb03bc56d9f911c270 Mon Sep 17 00:00:00 2001 From: jeparlefrancais Date: Fri, 22 Nov 2024 23:44:21 -0500 Subject: [PATCH 4/5] Add entry to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 64f097c..6e33e6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ Work in progress, to be added to next release notes. ### v0.5.10 +* Added `useNavigation` hook to the module's export ([#2](https://github.com/jsdotlua/roact-navigation/pull/2)) * Added "non-transparent, see-through card" support to RobloxStackView ([#148](https://github.com/Roblox/roact-navigation-internal/pull/148)) ### v0.5.9 From e3562dae4d4dd734d98664adaa9549321380a045 Mon Sep 17 00:00:00 2001 From: jeparlefrancais Date: Fri, 22 Nov 2024 23:47:39 -0500 Subject: [PATCH 5/5] Fix release workflow --- .github/workflows/release.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bb131fb..d1eca40 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -120,12 +120,12 @@ jobs: fail-fast: false matrix: include: - - artifact-name: react-testing-library.rbxm - path: build/react-testing-library.rbxm + - artifact-name: roact-navigation.rbxm + path: build/roact-navigation.rbxm asset-type: application/octet-stream - - artifact-name: react-testing-library-dev.rbxm - path: build/debug/react-testing-library.rbxm + - artifact-name: roact-navigation-dev.rbxm + path: build/debug/roact-navigation.rbxm asset-type: application/octet-stream steps: - uses: actions/checkout@v4