refactor: replace property with class constant

Author: DannyvdSluijs

tests/Drafts/BaseDraftTestCase.php

@@ -9,7 +9,7 @@
 abstract class BaseDraftTestCase extends BaseTestCase
 {
     /** @var string */
-    protected $relativeTestsRoot = '/../../vendor/json-schema/json-schema-test-suite/tests';
+    protected const RELATIVE_TESTS_ROOT = '/../../vendor/json-schema/json-schema-test-suite/tests';
 
     /**
      * @return array<string, array{string, string}>

tests/Drafts/Draft3Test.php

@@ -76,8 +76,8 @@ public function refPreventsASiblingIdFromChangingTheBaseUriProvider(): \Generato
     protected function getFilePaths(): array
     {
         return [
-            realpath(__DIR__ . $this->relativeTestsRoot . '/draft3'),
-            realpath(__DIR__ . $this->relativeTestsRoot . '/draft3/optional')
+            realpath(__DIR__ . self::RELATIVE_TESTS_ROOT . '/draft3'),
+            realpath(__DIR__ . self::RELATIVE_TESTS_ROOT . '/draft3/optional')
         ];
     }
 

tests/Drafts/Draft4Test.php

@@ -23,8 +23,8 @@ class Draft4Test extends BaseDraftTestCase
     protected function getFilePaths(): array
     {
         return [
-            realpath(__DIR__ . $this->relativeTestsRoot . '/draft4'),
-            realpath(__DIR__ . $this->relativeTestsRoot . '/draft4/optional')
+            realpath(__DIR__ . self::RELATIVE_TESTS_ROOT . '/draft4'),
+            realpath(__DIR__ . self::RELATIVE_TESTS_ROOT . '/draft4/optional')
         ];
     }