Errors if JULIA_DEPOT_PATH is set

[marius311]

Sorry if I'm missing something but the below logic to me seems like only ~/.julia will be checked, regardless of what Base.DEPOT_PATH or JULIA_DEPOT_PATH is?:

SymbolServer.jl/src/SymbolServer.jl

Line 42 in 2201c26

push!(empty!(Base.DEPOT_PATH), joinpath(homedir(), ".julia"))

E.g.:

julia> ENV["JULIA_DEPOT_PATH"]
"/usr/local/share/julia"

julia> Base.DEPOT_PATH
1-element Vector{String}:
 "/usr/local/share/julia"

julia> SymbolServer.get_general_pkgs()
ERROR: UndefVarError: `PkgEntry` not defined
Stacktrace:
 [1] get_general_pkgs()
   @ SymbolServer ~/.vscode-server/extensions/julialang.language-julia-1.127.2/scripts/packages/SymbolServer/src/SymbolServer.jl:46
 [2] top-level scope
   @ REPL[11]:1

The error is then triggered because it hits the i===nothing branch and then PkgEntry wasn't defined. This ends up making julia-vscod reindex everything instead of using cache files in environments with JULIA_DEPOT_PATH set.